[ISSUE 336] Implement footer for static site #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daphnegold
commented
Aug 29, 2023
| @@ -9,6 +9,12 @@ module.exports = { | |||
| // https://nextjs.org/docs/basic-features/eslint | |||
| "next/core-web-vitals", | |||
| ], | |||
| rules: { | |||
There was a problem hiding this comment.
This is in next.js template now, added it here to prevent another ignore in this PR
daphnegold
force-pushed
the
daphnegold/issue-336-footer
branch
from
e2b563f to
920ca26
Compare
andycochran
reviewed
Aug 30, 2023
andycochran
reviewed
Aug 30, 2023
|
|
||
| return ( | ||
| <Identifier data-testid="identifier"> | ||
| <IdentifierMasthead aria-label="Agency identifier"> | ||
| <IdentifierLogos> | ||
| <IdentifierLogo href="#">{logoImage()}</IdentifierLogo> | ||
| <IdentifierLogo href="#">{logoImage}</IdentifierLogo> |
There was a problem hiding this comment.
Why was this even a function before? 🤷
andycochran
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #336
Time to review: 8 mins
Changes proposed
SocialLinkmini component because the @trussworks one is not that useful for us (lives with footer now because it's not used anywhere else, could easily be moved and exported later)<img>tagsContext for reviewers
Pull down branch, run
make storybookand check out the layout and footer stories.Additional information
Desktop
Mobile