[ISSUE 406] Fix deploy Github Actions workflow #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
reviewed
Aug 23, 2023
Comment on lines
-8
to
-15
| # !! Uncomment the following lines once you've set up the dev environment and ready to turn on continuous deployment | ||
| # push: | ||
| # branches: | ||
| # - 'main' | ||
| # paths: | ||
| # - 'frontend/**' | ||
| # - 'bin/**' | ||
| # - 'infra/**' |
There was a problem hiding this comment.
Why is that? We have a dev environment set up
There was a problem hiding this comment.
sorry i totally thought i was reviewing a Pr in a different repo
daphnegold
force-pushed
the
daphnegold/issue-406-build-publish-fix
branch
from
92f73ec to
d285140
Compare
SammySteiner
approved these changes
Aug 24, 2023
| app_name: | ||
| description: "name of application folder under infra directory" | ||
| required: true | ||
| type: string |
There was a problem hiding this comment.
Will this fail if something other than frontend or api is entered? In that case should we make this type a choice instead of string to reduce the chance of mistakes?
There was a problem hiding this comment.
It won't run if you don't manage to type the app name correctly. We have another ticket to work on monorepo structure of Github Actions after integrating backend. See #285. The infrastructure for the api doesn't exist yet, so adding api as a choice to deploy would fail for that reason.
daphnegold
force-pushed
the
daphnegold/issue-406-build-publish-fix
branch
from
9a8fe3a to
31917b6
Compare
daphnegold
force-pushed
the
daphnegold/issue-406-build-publish-fix
branch
5 times, most recently
from
f0b6adf to
e17a3ff
Compare
daphnegold
force-pushed
the
daphnegold/issue-406-build-publish-fix
branch
from
e17a3ff to
9fbfd1a
Compare
lorenyu
reviewed
Aug 25, 2023
|
updates look good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #406
Time to review: 5 mins
Changes proposed
APP_NAMEin makefileAPP_NAMEto all relevant make commandscd-frontend.ymlthat callsdeploy.ymlTest workflow dispatch: https://github.com/HHS/grants-equity/actions/runs/5957648324
On PR
Dispatch workflow
cmd:
gh workflow run cd-frontend.yml --ref daphnegold/issue-406-build-publish-fix --app-name frontendVuln scans
https://github.com/HHS/grants-equity/actions/runs/5967002978?pr=407
end-to-end infra tests
https://github.com/HHS/grants-equity/actions/runs/5968825293/job/16193471947?pr=407