[ Issue 357 ] Identifier section #398
Conversation
| /> | ||
| </IdentifierIdentity> | ||
| </IdentifierMasthead> | ||
| <IdentifierLinks navProps={{ "aria-label": "Important links" }}> |
There was a problem hiding this comment.
Just a thought/question (please take w/ a grain of salt): Would it be possible to loop thru these links and code the element only once? Haven't thought thru exactly how that'd work… it'd mean moving the URIs to a separate file with their texts, a lookup table (ew), or something. Anyway, other NextJS projects Nave has kept all external links in an object (routes.external.[agency]) in the routes file. Maybe we don't need that much organization yet, or need to over-optimize, and hardcoding here is fine. 🤷
There was a problem hiding this comment.
@andycochran Is this what you had in mind?
There was a problem hiding this comment.
Ooh! Slick. Yeah. I like that the markup is just in there once, and it'll be easy if we need to add/edit/remove links.
Summary
Fixes #357
Time to review: 10 minutes
Changes proposed
Context for reviewers
I found and used the HHS logo, based on this usage documentation: https://www.hhs.gov/web/policies-and-standards/web-policies/logo-seal-and-symbol-policies/index.html#logo
Got the white version, for black backgrounds, here: https://www.hhs.gov/web/services-and-resources/icon-and-widget-library/index.html
I assume that all checks out.
Additional information
Desktop
Mobile
Story
Test Coverage