Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 299] Set up front-end infrastructure in AWS #381

Merged
merged 27 commits into from
Aug 23, 2023

Conversation

daphnegold
Copy link
Contributor

@daphnegold daphnegold commented Aug 17, 2023

Summary

Fixes #299

Time to review: 20 mins

Changes proposed

Integrates https://github.com/navapbc/template-infra into grants-equity

Context for reviewers

Infrastructure has been deployed to AWS and front-end app is running there in dev cluster. Includes account level infrastructure. :)

http://frontend-dev-143463875.us-east-1.elb.amazonaws.com/

Screenshot 2023-08-22 at 3 07 02 PM

…template overwrite because we've already made our own
@daphnegold daphnegold added the topic: infra Infrastructure related tickets label Aug 17, 2023
@daphnegold daphnegold force-pushed the daphnegold/issue-299-frontend-infra branch from b5b7a31 to 2d4598d Compare August 21, 2023 19:30
@daphnegold daphnegold force-pushed the daphnegold/issue-299-frontend-infra branch 2 times, most recently from 51658df to 37a1f68 Compare August 21, 2023 22:45
@daphnegold daphnegold force-pushed the daphnegold/issue-299-frontend-infra branch from 8f30575 to 89f46d7 Compare August 22, 2023 21:29
@daphnegold daphnegold marked this pull request as ready for review August 22, 2023 22:08
Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work and progress!

(blocking): We need to address the docs/ folder. Ultimately it would be integrated with the documentation folder.

For this PR I think we could remove the docs/ folder and create a separate ticket to properly integrate it, or integrate the folder in this PR.

The docs/infra folder could be moved to documentation/infra or documentation/architecture. The ADRs should have a happy home in documentation/decisions/, but that could be its own PR as well.

If there is energy to integrate the docs in this PR, would work as well.

@daphnegold daphnegold requested a review from acouch August 23, 2023 16:57
Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (blocking):

The documentation/decisions/infra are not formatted in the same way as the others. We have also not discussed whether to separate ADRs into separate folders AFAIK. I would recommend removing the infra ADRs for another ticket or to include the ADRs in the newer date format.

documentation/infra/infra material could be moved to documentation/infra and the redundant infra/infra folder removed.

I would recommend removing /documentation/infra/code-reviews.md and releases.md as is infra specific.

@daphnegold
Copy link
Contributor Author

daphnegold commented Aug 23, 2023

suggestion (blocking):

The documentation/decisions/infra are not formatted in the same way as the others. We have also not discussed whether to separate ADRs into separate folders AFAIK. I would recommend removing the infra ADRs for another ticket or to include the ADRs in the newer date format.

Actually don't think it's worthwhile to change the format. We are just creating more busy work for ourselves whenever we pull in changes from the infrastructure template. The format doesn't need to be blocking, does it? Also don't think it's worthwhile blocking this PR based on a discussion on if it's okay to have sub-folders in our ADR directory. I question the logic of having one super-giant directory of dated ADRs with no index and no organization anyway.

tl;dr there's nothing preventing us from iterating on this, creating another ticket. No need to delete. Let's get it merged.

Thanks for the other comments, makes sense and things that got lost in this giant PR.

@daphnegold daphnegold requested a review from acouch August 23, 2023 19:16
Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs folder. Looks a lot cleaner now. I think the difference in format introduces a new change that could be best handled in a separate ticket. I would typically hold off on introducing that change until the ticket is created, but don't want to hold up this amazing work. Let's discuss when we get a chance.

@daphnegold daphnegold merged commit 5e64910 into main Aug 23, 2023
9 checks passed
@daphnegold daphnegold deleted the daphnegold/issue-299-frontend-infra branch August 23, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infra Infrastructure related tickets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Set up front-end infrastructure in AWS
2 participants