[Issue #3540] AWS Pinpoint Mock setup #3652
Open
+226
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3540
Time to review: 5 mins
Changes proposed
Adds basic setup to call AWS Pinpoint
Handles mocking queries for local development / unit tests
Context for reviewers
AWS Pinpoint is an AWS service we'll be using for sending email notifications to users. We don't yet have any of the infra setup for it, but the Nava infra template does have it setup, and I used it to test the behavior.
There will be more configuration needed in the future for things like the app ID, but I wasn't sure exactly how we'll manage that (one app per notification type, or just per env? Will leave to design to sort out).
We also won't send raw HTML emails and will instead setup email templates most likely which will require adjusting some of the parameters we pass in.
Additional information
With a quick local script, I was able to pass in a few parameters and send myself some emails:
I used this to verify the format of the response could be parsed / was setup correctly.