[Issue #3499] Make user token session typing cleaner #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3516
Time to review: 3 mins
Changes proposed
Add a utility method for fetching the user token session to handle type checking issues.
Context for reviewers
This removes the need to have
api_jwt_auth.current_user # type: ignorein every place we fetch the user.Note that we have to do some sort of type ignore/cast because the type is
None | Anyoncurrent_useras it's just whatever you return from the decode_token method.Additional information
All tests continue to pass which rely on fetching this