[Issue #2493] Allow certain agency fields to be null from the legacy values #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
mxk0,
widal001 and
andycochran
as code owners
doug-s-nava
pushed a commit
that referenced
this pull request
Oct 18, 2024
…values (#2513) ## Summary Fixes #2493 ### Time to review: __5 mins__ ## Changes proposed Modified three fields (ldapGp, description, label) in the agency table to be nullable Adjusted the transform agency process to allow these fields to be nullable as well ## Context for reviewers This isn't an issue in prod right now, but is accounting for a problem I found in the dev/staging environments. The agency data is stored in a very different way (key-value pairs) in the legacy data, and these fields are sometimes not present in the test data. There isn't any reason we should require them as we likely won't use them, so I'm letting them be nullable to let these agencies with the values null get populated in the lower envs. ## Additional information There is some additional context on #2494 --------- Co-authored-by: nava-platform-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2493
Time to review: 5 mins
Changes proposed
Modified three fields (ldapGp, description, label) in the agency table to be nullable
Adjusted the transform agency process to allow these fields to be nullable as well
Context for reviewers
This isn't an issue in prod right now, but is accounting for a problem I found in the dev/staging environments. The agency data is stored in a very different way (key-value pairs) in the legacy data, and these fields are sometimes not present in the test data. There isn't any reason we should require them as we likely won't use them, so I'm letting them be nullable to let these agencies with the values null get populated in the lower envs.
Additional information
There is some additional context on #2494