[DNM] [Issue 2507] upgrade storybook to version 8 #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is largely needed in order to work around a security issue with esbuild that is present in storybook until 8.4 which has not yet been release. Hold on this PR until we can upgrade to 8.4 without alphas
Summary
Fixes #2507
Time to review: 20 mins on basic functionality, longer to review security posture
Changes proposed
Upgrade to the latest version of Storybook.
Note that to get this working I ran the suggested upgrade script mentioned below, which eventually worked, but then had to fix the reference to our next config, which was not being found for some reason, in order to get storybook to load
https://storybook.js.org/docs/migration-guide
Context for reviewers
TBD
Additional information
Notes
it looks like Go 1.23 support in esbuild only came along last month in version 0.24 https://github.com/evanw/esbuild/releases/tag/v0.24.0
version 0.24 of esbuild is only supported in storybook core as of v8.4.0-alpha.4 storybookjs/storybook@c40aba2
so assuming we don't want to mess around with alphas I think we need to wait until storybook 8.4.0 is official.
In the meantime I have a PR up for the upgrade that we can work off of at that time. #2508