Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test TransformAgency ELT process in dev/staging #2494

Open
1 task
chouinar opened this issue Oct 16, 2024 · 2 comments
Open
1 task

Test TransformAgency ELT process in dev/staging #2494

chouinar opened this issue Oct 16, 2024 · 2 comments
Assignees

Comments

@chouinar
Copy link
Collaborator

Summary

Test process, fix any issues, create tickets as follow-ups.

Acceptance criteria

  • Note down observations
@chouinar chouinar self-assigned this Oct 16, 2024
@chouinar
Copy link
Collaborator Author

Created several follow-up tickets after doing one round of testing yesterday. Two issues identified:

  • Need to handle top-level agency names
  • Need to handle agencies without certain fields unconfigured that we don't intend to use anyways

#2490 - add top-level agency name to the API response
#2491 - add top-level agency info to the DB model
#2492 - populate the top-level agency info in the transform process
#2493 - ease up validation on some agency transformations

@chouinar
Copy link
Collaborator Author

Here are the agencies that failed to process when running in dev:


1 | GDIT-PDCM-LEV2 | Cannot create agency GDIT-PDCM-LEV2 as required fields are missing: AgencyContactCity
-- | -- | --
2 | GDIT-AG | Cannot create agency GDIT-AG as required fields are missing: AgencyContactCity
3 | GDIT-311 | Cannot create agency GDIT-311 as required fields are missing: AgencyContactCity
4 | GDIT-21 | Cannot create agency GDIT-21 as required fields are missing: AgencyContactCity
5 | GDIT-31 | Cannot create agency GDIT-31 as required fields are missing: AgencyContactCity
6 | GDIT-2 | Cannot create agency GDIT-2 as required fields are missing: AgencyContactCity
7 | GDIT-06282011 | Cannot create agency GDIT-06282011 as required fields are missing: AgencyContactCity
8 | GDIT-070120111 | Cannot create agency GDIT-070120111 as required fields are missing: AgencyContactCity
9 | GDIT-07012011 | Cannot create agency GDIT-07012011 as required fields are missing: AgencyContactCity
10 | dxprobeyd0000BA | Cannot create agency dxprobeyd0000BA as required fields are missing: ldapGp
11 | dxprobeyd00000F | Cannot create agency dxprobeyd00000F as required fields are missing: ldapGp
12 | dxprobeyd00006C | Cannot create agency dxprobeyd00006C as required fields are missing: ldapGp
13 |   | Cannot create agency as required fields are missing: ldapGp

Only GDIT-PDCM-LEV2 has any opportunities associated with it, and just 2 old ones. The rest of these are clearly test agencies. Odd that several of them have no contact city, that wasn't an issue in the prod data. While I'm fine adjusting to not have an ldapGp since we don't use it, I would prefer the contact info be intact. I could work around these old agencies if I manually created them + set the transformed flag. Just to get the errors to go away. I'll first fix the ldapGp issue though.

chouinar added a commit that referenced this issue Oct 17, 2024
…values (#2513)

## Summary
Fixes #2493

### Time to review: __5 mins__

## Changes proposed
Modified three fields (ldapGp, description, label) in the agency table
to be nullable

Adjusted the transform agency process to allow these fields to be
nullable as well

## Context for reviewers
This isn't an issue in prod right now, but is accounting for a problem I
found in the dev/staging environments. The agency data is stored in a
very different way (key-value pairs) in the legacy data, and these
fields are sometimes not present in the test data. There isn't any
reason we should require them as we likely won't use them, so I'm
letting them be nullable to let these agencies with the values null get
populated in the lower envs.

## Additional information
There is some additional context on
#2494

---------

Co-authored-by: nava-platform-bot <[email protected]>
doug-s-nava pushed a commit that referenced this issue Oct 18, 2024
…values (#2513)

## Summary
Fixes #2493

### Time to review: __5 mins__

## Changes proposed
Modified three fields (ldapGp, description, label) in the agency table
to be nullable

Adjusted the transform agency process to allow these fields to be
nullable as well

## Context for reviewers
This isn't an issue in prod right now, but is accounting for a problem I
found in the dev/staging environments. The agency data is stored in a
very different way (key-value pairs) in the legacy data, and these
fields are sometimes not present in the test data. There isn't any
reason we should require them as we likely won't use them, so I'm
letting them be nullable to let these agencies with the values null get
populated in the lower envs.

## Additional information
There is some additional context on
#2494

---------

Co-authored-by: nava-platform-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant