[fix] fix bugs in irt, mirt, parse_config

HFUT-LEC · Dec 18, 2023 · 68dc147 · 68dc147
1 parent ba6a481
commit 68dc147
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/edustudio/model/CD/irt.py b/edustudio/model/CD/irt.py
@@ -28,8 +28,8 @@ def __init__(self, cfg):
         super().__init__(cfg)
 
     def build_cfg(self):
-        if self.modeltpl_cfg['a_range']  < 0: self.modeltpl_cfg['a_range'] = None
-        if self.modeltpl_cfg['diff_range'] < 0: self.modeltpl_cfg['diff_range'] = None
+        if self.modeltpl_cfg['a_range'] is not None and self.modeltpl_cfg['a_range']  < 0: self.modeltpl_cfg['a_range'] = None
+        if self.modeltpl_cfg['diff_range'] is not None and self.modeltpl_cfg['diff_range'] < 0: self.modeltpl_cfg['diff_range'] = None
 
         self.n_user = self.datatpl_cfg['dt_info']['stu_count']
         self.n_item = self.datatpl_cfg['dt_info']['exer_count']

diff --git a/edustudio/model/CD/mirt.py b/edustudio/model/CD/mirt.py
@@ -30,7 +30,7 @@ def __init__(self, cfg):
         super().__init__(cfg)
 
     def build_cfg(self):
-        if self.modeltpl_cfg['a_range']  < 0: self.modeltpl_cfg['a_range'] = None
+        if self.modeltpl_cfg['a_range'] is not None and self.modeltpl_cfg['a_range']  < 0: self.modeltpl_cfg['a_range'] = None
 
         self.n_user = self.datatpl_cfg['dt_info']['stu_count']
         self.n_item = self.datatpl_cfg['dt_info']['exer_count']

diff --git a/edustudio/quickstart/parse_cfg.py b/edustudio/quickstart/parse_cfg.py
@@ -181,7 +181,7 @@ def get_global_cfg(
                     if k == 'cls': continue
                     # assert type(v) is None or type(cfg[config_name][k]) is type(v)
                     if k in atom_data_op_set:
-                        for kk,vv in datatpl_cfg_dict[k].items():
+                        for kk,vv in yaml_cfg[config_name].get(k, {}).items():
                             assert kk in cfg[config_name][k], f"invalid key: {kk}"
                             cfg[config_name][k][kk] = vv
                     else: