Merge pull request #16 from badranX/dkvmn_based

Fix DKVMN based loss, labels-predictions mismatch
HFUT-LEC · Dec 7, 2023 · 18d7312 · 18d7312
2 parents ba3cbb6 + 7c11254
commit 18d7312
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/edustudio/model/KT/deep_irt.py b/edustudio/model/KT/deep_irt.py
@@ -123,7 +123,7 @@ def predict(self, **kwargs):
             dict: The predictions of the model and the real situation
         """
         y_pd = self(**kwargs)
-        y_pd = y_pd[:, :-1]
+        y_pd = y_pd[:, 1:]
         y_pd = y_pd[kwargs['mask_seq'][:, 1:] == 1]
         y_gt = None
         if kwargs.get('label_seq', None) is not None:
@@ -141,7 +141,7 @@ def get_main_loss(self, **kwargs):
             dict: {'loss_main': loss_value}
         """
         y_pd = self(**kwargs)
-        y_pd = y_pd[:, :-1]
+        y_pd = y_pd[:, 1:]
         y_pd = y_pd[kwargs['mask_seq'][:, 1:] == 1]
         y_gt = kwargs['label_seq'][:, 1:]
         y_gt = y_gt[kwargs['mask_seq'][:, 1:] == 1]

diff --git a/edustudio/model/KT/dkvmn.py b/edustudio/model/KT/dkvmn.py
@@ -84,7 +84,7 @@ def forward(self, exer_seq, label_seq, **kwargs):
     @torch.no_grad()
     def predict(self, **kwargs):
         y_pd = self(**kwargs)
-        y_pd = y_pd[:, :-1]
+        y_pd = y_pd[:, 1:]
         y_pd = y_pd[kwargs['mask_seq'][:, 1:] == 1]
         y_gt = None
         if kwargs.get('label_seq', None) is not None:
@@ -97,7 +97,7 @@ def predict(self, **kwargs):
 
     def get_main_loss(self, **kwargs):
         y_pd = self(**kwargs)
-        y_pd = y_pd[:, :-1]
+        y_pd = y_pd[:, 1:]
         y_pd = y_pd[kwargs['mask_seq'][:, 1:] == 1]
         y_gt = kwargs['label_seq'][:, 1:]
         y_gt = y_gt[kwargs['mask_seq'][:, 1:] == 1]