feat(http): add information on request to know it it's from tls or not #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/identify-secure
branch
from
776ea11 to
b97e285
Compare
|
Close in favor of #1200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to be able for an user to know if a request comes from a secure context or not.
There is no way to know actually when listening on both secure and not secure context if a incoming request is using tls or not. I added this information to the
Extensionspart of the request, so now an user can, per exemple, automatically redirect an user to https if coming from http.EDIT : I also updated the client to be able to force using a secure context or not and avoid calling acceptor if not in a secure context