fix(client): remove host header on http2 / http3 #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Do you mind making a quick clippy fix as the project is targeting nightly rust for linting and formatting? |
joelwurtz
force-pushed
the
fix/no-host-header
branch
from
194be32 to
6e28e79
Compare
|
Should be good |
|
relevant failure are due to home package update i think cf https://github.com/rust-lang/cargo/blob/master/crates/home/CHANGELOG.md |
|
np. I'll resolve the ci issue later as the it has nothing to do with PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I was playing a bit with the client, and it seems that it has the same bug as the client from actix-web actix/actix-web#3495 where having an host header on nginx will cause a 400.
This header is not used when on http2/http3 since it use the pseudo authority header, so i removed it in both cases to avoid this problem (don't know if nginx will have the same problem with http3, but at least it prevent it and should be harmless)