clippy fix.

client/src/response.rs

@@ -181,8 +181,6 @@ trait Collectable {
     fn with_capacity(cap: usize) -> Self;
 
     fn try_extend_from_slice(&mut self, slice: &[u8]) -> Result<(), Error>;
-
-    fn len(&self) -> usize;
 }
 
 impl Collectable for BytesMut {
@@ -196,11 +194,6 @@ impl Collectable for BytesMut {
         self.extend_from_slice(slice);
         Ok(())
     }
-
-    #[inline]
-    fn len(&self) -> usize {
-        Self::len(self)
-    }
 }
 
 impl Collectable for Vec<u8> {
@@ -214,11 +207,6 @@ impl Collectable for Vec<u8> {
         self.extend_from_slice(slice);
         Ok(())
     }
-
-    #[inline]
-    fn len(&self) -> usize {
-        Self::len(self)
-    }
 }
 
 impl Collectable for String {
@@ -232,9 +220,4 @@ impl Collectable for String {
         self.push_str(str);
         Ok(())
     }
-
-    #[inline]
-    fn len(&self) -> usize {
-        Self::len(self)
-    }
 }

http-rate/src/state/in_memory.rs

@@ -42,6 +42,7 @@ impl InMemoryState {
         decision.map(|(result, _)| result)
     }
 
+    #[cfg(test)]
     pub(crate) fn is_older_than(&self, nanos: Nanos) -> bool {
         self.0.load(Ordering::Relaxed) <= nanos.into()
     }

http-rate/src/state/keyed.rs

@@ -1,8 +1,6 @@
 use core::hash::Hash;
 
-use crate::{
-    gcra::NotUntil, nanos::Nanos, quota::Quota, snapshot::RateSnapshot, state::RateLimiter, state::StateStore, timer,
-};
+use crate::{gcra::NotUntil, quota::Quota, snapshot::RateSnapshot, state::RateLimiter, state::StateStore, timer};
 
 #[cfg(test)]
 use core::num::NonZeroU32;
@@ -87,6 +85,7 @@ where
     }
 }
 
+#[cfg(test)]
 /// Keyed rate limiters that can be "cleaned up".
 ///
 /// Any keyed state store implementing this trait allows users to evict elements that are
@@ -98,7 +97,7 @@ where
 /// shrinking.
 pub(crate) trait ShrinkableKeyedStateStore<K: Hash>: KeyedStateStore<K> {
     /// Remove those keys with state older than `drop_below`.
-    fn retain_recent(&self, drop_below: Nanos);
+    fn retain_recent(&self, drop_below: crate::nanos::Nanos);
 
     /// Shrinks the capacity of the state store, if possible.
     ///
@@ -179,7 +178,7 @@ pub(crate) type DefaultKeyedStateStore<K> = HashMapStateStore<K>;
 mod test {
     use core::{marker::PhantomData, num::NonZeroU32};
 
-    use crate::timer::FakeRelativeClock;
+    use crate::{nanos::Nanos, timer::FakeRelativeClock};
 
     use super::*;
 

http-rate/src/state/keyed/hashmap.rs

@@ -4,7 +4,7 @@ use std::{collections::HashMap, sync::Mutex};
 
 use crate::{
     nanos::Nanos,
-    state::{keyed::ShrinkableKeyedStateStore, InMemoryState, StateStore},
+    state::{InMemoryState, StateStore},
 };
 
 #[cfg(test)]
@@ -38,7 +38,8 @@ where
     }
 }
 
-impl<K> ShrinkableKeyedStateStore<K> for HashMapStateStore<K>
+#[cfg(test)]
+impl<K> crate::state::keyed::ShrinkableKeyedStateStore<K> for HashMapStateStore<K>
 where
     K: Hash + Eq + Clone,
 {

http-rate/src/timer.rs

@@ -134,14 +134,6 @@ impl Timer for DefaultTimer {
     }
 }
 
-pub trait ReasonablyRealtime: Timer {
-    fn reference_point(&self) -> Self::Instant {
-        self.now()
-    }
-}
-
-impl ReasonablyRealtime for DefaultTimer {}
-
 #[cfg(test)]
 mod test {
     use super::*;

http/src/lib.rs

@@ -41,6 +41,7 @@ mod builder;
 #[cfg(feature = "runtime")]
 mod service;
 mod tls;
+#[cfg(feature = "runtime")]
 mod version;
 
 pub mod body;

http/src/version.rs

@@ -13,27 +13,22 @@ pub trait AsVersion {
     }
 }
 
-#[cfg(feature = "runtime")]
-mod io_impl {
-    use super::*;
-
-    impl AsVersion for xitca_io::net::Stream {
-        #[inline]
-        fn as_version(&self) -> Version {
-            match *self {
-                Self::Tcp(..) => Version::HTTP_11,
-                #[cfg(unix)]
-                Self::Unix(..) => Version::HTTP_11,
-                #[cfg(feature = "http3")]
-                Self::Udp(..) => Version::HTTP_3,
-            }
+impl AsVersion for xitca_io::net::Stream {
+    #[inline]
+    fn as_version(&self) -> Version {
+        match *self {
+            Self::Tcp(..) => Version::HTTP_11,
+            #[cfg(unix)]
+            Self::Unix(..) => Version::HTTP_11,
+            #[cfg(feature = "http3")]
+            Self::Udp(..) => Version::HTTP_3,
         }
     }
+}
 
-    impl AsVersion for xitca_io::net::TcpStream {
-        #[inline]
-        fn as_version(&self) -> Version {
-            Version::HTTP_11
-        }
+impl AsVersion for xitca_io::net::TcpStream {
+    #[inline]
+    fn as_version(&self) -> Version {
+        Version::HTTP_11
     }
 }