Test 4.0.0 #54
Merged
Test 4.0.0 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…experimentation was done in the notebook; it currently houses an example of part of a function to eventually be incorporated into the sim_prep module (the code will be removed once it is migrated to the sim_prep module). Updated the tools module's constructor to import the sim_prep module. Updated the sim_prep module to contain documented placeholder functions for various steps needed to prepare the simulation data for the test.
…nd key for autocorrelation (so noise can be added pre-inflation) and allow the user to specify a receiver temperature. Added some comments with concerns/questions. Fleshed out most of the placeholder functions in sim_prep; only remaining step for generating H1C-like files from RIMEz files and reference H1C files is to develop the code for finding the intersection between the arrays and appropriately downselecting the RIMEz data. Also a bunch of small formatting changes to docstrings and comments.
…menting with things. More updates anticipated before ready for handoff.
…nt can't be inferred from the passed filename. Change docstring to a one-liner.
… to perform the antenna matching/selection.
… adding systematics (gains, reflections, xtalk) written.
steven-murray
commented
Apr 2, 2020
…data as best as possible. Update notebook to show that the resulting files are properly constructed and may be redundantly and absolutely calibrated. There are also some changes to the add_noise function that have not yet been completed; this will be fixed in the next commit.
…pdates to the function. Note: the beam polynomial still needs to be updated to agree with the beam model used in the RIMEz sim.
…need to debug/test.
Added a function for simulating a shoulder/spectrum of reflections. Mostly just a thin wrapper around add_reflections.
Extend the behavior of prepare_sim_files pre-processing to modify time variation parameters for linear gain variation such that reflections may also have a linear amplitude drift over the course of a night.
Extend add_reflections to handle applying multiple reflections (implicitly understood as the thing to do when amp/dly are passed as iterables). Simplify add_reflection_spectrum to be a very thin wrapper around add_reflections. Update vary_gains_in_time to vary the gains in-place. Still need to run some preliminary tests.
Ensure that each reflection in the reflection shoulder has its own delay/amplitude jitter, rather than broadcasting that jitter to every reflection in the shoulder.
Update the add_reflections function to allow for multiple values of amp_scale and dly_spread to be specified.
Fixed a typo; also added extra parameter checking for multiple reflections.
Add a clause to the main loop of the prepare_data batch script so that the EoR-only, chunked files are produced when the first day of the set of observing days is simulated.
This is for the new run with a slightly stronger EoR signal than was used in previous runs. Since the foregrounds haven't changed, and nothing about the systematics simulation has changed, foreground-only files will not be recreated.
This commit introduces a few new and important plots to the end-to-end validation notebook. In particular, the notebook now contains a comparison of real data to simulated data, as well as a single figure that shows the progression of systematics added to the simulation. The code for plotting waterfalls has also been removed and now the notebook uses the fancy plotting tools available in uvtools.
There was a bug that caused the script to fall over if the configuration file had an entry for noise, but did not have a corresponding entry for setting the random seed. This has been fixed. Note that the bug did not affect the quality of any of the previous validation simulation products.
|
@r-pascua The notebook looks good. I just have a few comments:
Other than that, I think we're good to go. |
|
@steven-murray I think you may be looking at an outdated version of the notebook. (If you're clicking the ReviewNB link, then it might be showing you a very old version.) Here's a rendered version of the updated notebook: https://nbviewer.jupyter.org/github/HERA-Team/hera-validation/blob/test-4.0.0/test-series/4/test-4.0.0a.ipynb All of the concerns raised in the previous comment should already be addressed. The only thing that I think needs to be addressed is that I only have a question mark put down next to the "Criteria" item in the description cell. |
|
Ugh. OK, sorry for the noise. Yes, the current notebook looks excellent. For the criteria, I'd just say "N/A: test criteria appear in notebook 4.0.0c, in which power spectra are calculated". |
|
Ok, great! Should I just make an "approve" review after pushing that change? |
|
Yeah, sounds good! |
r-pascua
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #42.