Skip to content

Commit

Permalink
Merge pull request #43 from HBPMedical/fix/exareme_now_ignores_pathol…
Browse files Browse the repository at this point in the history
…ogy_version

Now a pathology has a version until Exareme is completely replaced by…
  • Loading branch information
KFilippopolitis authored Jul 26, 2022
2 parents 0a6f68f + 94687d7 commit 92590d4
Show file tree
Hide file tree
Showing 4 changed files with 68 additions and 2 deletions.
49 changes: 49 additions & 0 deletions .github/workflows/publish_testing_images.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Publish testing images

on:
pull_request:
branches:
- master

jobs:
build_and_push:
name: Build image and push to dockerhub
runs-on: ubuntu-latest
steps:
- name: Check out repository
uses: actions/checkout@v2

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1

- name: Log in to Docker Hub
uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Load cached image
uses: actions/cache@v2
with:
path: /tmp/.buildx-cache/portal-backend
key: buildx-backend
restore-keys: buildx-backend

- name: Build and Push image to dockerhub
uses: docker/build-push-action@v2
with:
context: .
file: ./Dockerfile
push: true
tags: hbpmip/portal-backend:testing
cache-from: type=local,src=/tmp/.buildx-cache/portal-backend
cache-to: type=local,dest=/tmp/.buildx-cache-new/portal-backend

# Temp fix
# https://github.com/docker/build-push-action/issues/252
# https://github.com/moby/buildkit/issues/1896
- name: Move Docker images cache
run: |
rm -rf /tmp/.buildx-cache
mv /tmp/.buildx-cache-new /tmp/.buildx-cache
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public MIPEngineAlgorithmRequestDTO(UUID experimentUUID, List<ExaremeAlgorithmRe
inputData.setData_model(parameter.getValue());
break;
case "filter":
if (!parameter.getValue().equals(""))
if (parameter.getValue() != null && !parameter.getValue().equals(""))
inputData.setFilters(JsonConverters.convertJsonStringToObject(parameter.getValue(), MIPEngineAlgorithmRequestDTO.Filter.class));
break;
default:
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/eu/hbp/mip/models/DTOs/PathologyDTO.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ public class PathologyDTO {
@SerializedName("code")
private String code;

@SerializedName("version")
private String version;


@SerializedName("label")
private String label;

Expand Down
15 changes: 14 additions & 1 deletion src/main/java/eu/hbp/mip/services/ExperimentService.java
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,20 @@ private ExaremeAlgorithmResultDTO runExaremeExperiment(ExperimentDTO experimentD
String algorithmEndpoint = queryExaremeUrl + "/" + algorithmName;
List<ExaremeAlgorithmRequestParamDTO> algorithmParameters
= experimentDTO.getAlgorithm().getParameters();
String algorithmBody = gson.toJson(algorithmParameters);
List<ExaremeAlgorithmRequestParamDTO> algorithmParametersWithoutPathologyVersion = new ArrayList<>();

for (ExaremeAlgorithmRequestParamDTO algorithmParameter : algorithmParameters)
{
if (algorithmParameter.getName().equals("pathology")) {
List<String> pathology_info = Arrays.asList(algorithmParameter.getValue().split(":", 2));
String pathology_code = pathology_info.get(0);
algorithmParameter.setValue(pathology_code);
}
algorithmParametersWithoutPathologyVersion.add(algorithmParameter);

}

String algorithmBody = gson.toJson(algorithmParametersWithoutPathologyVersion);
logger.LogUserAction("Exareme algorithm execution. Endpoint: " + algorithmEndpoint);
logger.LogUserAction("Exareme algorithm execution. Body: " + algorithmBody);

Expand Down

0 comments on commit 92590d4

Please sign in to comment.