Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh webhook signature unit test #82

Merged
merged 2 commits into from
May 27, 2024
Merged

gh webhook signature unit test #82

merged 2 commits into from
May 27, 2024

Conversation

wojpo
Copy link
Collaborator

@wojpo wojpo commented May 24, 2024

tests for checking if signature is correct

@wojpo
gh webhook signature unit test
612c408 
tests for checking if signature is correct
@wojpo wojpo requested a review from Norbiros as a code owner May 24, 2024 19:14
@wojpo wojpo linked an issue May 24, 2024 that may be closed by this pull request
[Enhancement]: Basic unit tests #78
Closed
@Kubaryt Kubaryt requested review from a team and Kubaryt May 24, 2024 19:16
Kubaryt
Kubaryt previously approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@Kubaryt Kubaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enchancement -> enhancement,
use kebab-case for branch names,
name PRs in such convention:
<PR_type>: PR_title
So in this case:
Feat: GH webhook signature unit test

Norbiros
Norbiros requested changes May 24, 2024
View reviewed changes
core/tests.py Outdated Show resolved Hide resolved
@wojpo wojpo requested a review from Kubaryt May 26, 2024 00:12
@wojpo wojpo merged commit eafe625 into main May 27, 2024
2 checks passed
@wojpo wojpo deleted the enchancement/basicUnitTests branch May 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubaryt Kubaryt Kubaryt approved these changes

@Norbiros Norbiros Norbiros approved these changes

Assignees

@wojpo wojpo

Labels
difficulty: medium type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Basic unit tests
3 participants
@wojpo @Kubaryt @Norbiros