Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Discord auth system #68

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feat: Discord auth system #68

wants to merge 6 commits into from

Conversation

SzczurekYT
Copy link

@SzczurekYT SzczurekYT commented May 2, 2024 •
edited by goteusz-maszyk
Loading

BY @goteusz-maszyk:

Closes #49

TODOs:

@SzczurekYT SzczurekYT requested a review from Norbiros as a code owner May 2, 2024 10:08
@SzczurekYT SzczurekYT requested a review from Kubaryt May 2, 2024 10:08
goteusz-maszyk
goteusz-maszyk requested changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@goteusz-maszyk goteusz-maszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This what I've marked plus:

  • Make it so only authenticated members are allowed to view gwardia stuff
  • Rework navbar to make it possible to add logged-in-only or logged-out-only links

core/discord_auth.py Outdated Show resolved Hide resolved
core/discord_api.py Outdated Show resolved Hide resolved
core/discord_api.py Show resolved Hide resolved
core/discord_api.py Outdated Show resolved Hide resolved
core/views.py Outdated Show resolved Hide resolved
core/urls.py Outdated Show resolved Hide resolved
core/views.py Outdated Show resolved Hide resolved
core/views.py Outdated Show resolved Hide resolved
core/views.py Show resolved Hide resolved
Norbiros
Norbiros requested changes May 2, 2024
View reviewed changes
core/discord_api.py Outdated Show resolved Hide resolved
core/discord_auth.py Outdated Show resolved Hide resolved
core/discord_api.py Outdated Show resolved Hide resolved
core/discord_api.py Outdated Show resolved Hide resolved
core/discord_auth.py Outdated Show resolved Hide resolved
core/discord_auth.py Outdated Show resolved Hide resolved
@Kubaryt Kubaryt linked an issue May 2, 2024 that may be closed by this pull request
[Feat]: Create auth system #49
Open
@Kubaryt Kubaryt requested a review from Norbiros May 11, 2024 11:36
@Norbiros Norbiros mentioned this pull request May 17, 2024
Open
@Kubaryt Kubaryt requested a review from goteusz-maszyk May 20, 2024 20:22
Kubaryt
Kubaryt requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@Kubaryt Kubaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make code pass all checks

@goteusz-maszyk goteusz-maszyk requested a review from Kubaryt June 11, 2024 20:04
Kubaryt
Kubaryt requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@Kubaryt Kubaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to create 4 migrations in 1 commit, merge them

Norbiros
Norbiros requested changes Jun 12, 2024
View reviewed changes
core/context_processors.py Outdated Show resolved Hide resolved
core/discord_api.py Outdated Show resolved Hide resolved
core/discord_api.py Outdated Show resolved Hide resolved
core/discord_auth.py Outdated Show resolved Hide resolved
Norbiros
Norbiros requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@Norbiros Norbiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It's currently hard to develop the website because you need to create a Discord bot and configure environment variables. To improve DX, maybe add a setting to check (or check if website is in dev mode) and log users in with a random, template user directly, bypassing the Discord login.
  2. Add a .env.example file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubaryt Kubaryt Kubaryt requested changes

@Norbiros Norbiros Norbiros requested changes

@goteusz-maszyk goteusz-maszyk Awaiting requested review from goteusz-maszyk

Requested changes must be addressed to merge this pull request.

Assignees

@goteusz-maszyk goteusz-maszyk

Labels
difficulty: hard type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: Create auth system
4 participants
@SzczurekYT @goteusz-maszyk @Kubaryt @Norbiros