Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ruff and Poetry Github Actions (#2) #6

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

Kubaryt
Copy link
Member

@Kubaryt Kubaryt commented Mar 21, 2024

  • Added YML that performs ruff lints and poetry checks on push

Important

It's my first time doing github actions, I have used LLMs and Google, but still it is probable, that I have made some huge mistakes

- Added YML that performs ruff lints and poetry checks on push
@Kubaryt Kubaryt self-assigned this Mar 21, 2024
@Kubaryt Kubaryt linked an issue Mar 22, 2024 that may be closed by this pull request
@Kubaryt Kubaryt removed a link to an issue Mar 22, 2024
@Kubaryt Kubaryt linked an issue Mar 22, 2024 that may be closed by this pull request
- Defined python version
- Deleted ruff check --fix
- Fixed check in args
- Added run image to poetry checks
@Kubaryt Kubaryt marked this pull request as ready for review March 22, 2024 14:39
@Kubaryt Kubaryt requested a review from Norbiros March 22, 2024 14:39
Copy link
Member

@Norbiros Norbiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect!

.github/workflows/ruff-code-checks-and-poetry-cecks.yml Outdated Show resolved Hide resolved
@Kubaryt Kubaryt merged commit a5bec5d into main Mar 22, 2024
2 checks passed
@Kubaryt Kubaryt deleted the feat/Ruff-and-Poetry-GH-Actions branch March 22, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Create GitHub actions
3 participants