-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line Optimization in Public Transport #132
Conversation
This looks awesome, thanks for the great work @Marika-K! The multi-objective component is a particularly nice feature. @stevedwards in applications terms I think this quite different from the network design mod, and it would make sense to have both of them in the library separately. Thoughts? |
Yeah, this is super, super nice. Love everything about it. The level of abstraction is perfect for an optimod. Yeah @simonbowly totally makes sense to have them separately. Great work @Marika-K |
Thanks! I am happy that this Optimod fits. |
Looks like a numerics problem, happens from time to time with that mod. It looks like all your tests are passing so nothing to worry about. Just mark this PR "ready for review" when ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marika-K thanks for the great work, and sorry for the delay. I added a couple of comments.
I also did a little polishing of the introduction text, could you check that my changes look ok there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few more comments. After these, I think it's good to go!
Thanks, Simon! |
Looks good, thanks! |
And again, great work @Marika-K! This is a really nice addition :-) |
Description
A new optimod for line optimization in public transport.
There is currently no issue for this optimod but it is related to Network Design Optimod #36
Checklist
gurobi_optimods
installable packagetests/
gurobi_optimods.datasets
for loading data)Have a nice day!