Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .kotlin from Kotlin 2.0.0 in .gitignore #406

Merged
merged 1 commit into from
May 27, 2024

Conversation

EchoEllet
Copy link
Contributor

@EchoEllet EchoEllet commented May 25, 2024

It looks like this project has been updated to support and use Kotlin 2.0.0 in 7.5.0 with

but when building the project you will get this message in the IDE:

image

Also using git add . will add .kotlin will add the file to the staging area which might cause it to be accidently committed, it will be generated when building the project using ./gradlew build or any other way

see this for more info: https://kotlinlang.org/docs/whatsnew20.html#new-directory-for-kotlin-data-in-gradle-projects

Not related to the PR

There is a warning when building the project:

The Kotlin Gradle plugin was loaded multiple times in different subprojects, which is not supported and may break the build. 
This might happen in subprojects that apply the Kotlin plugins with the Gradle 'plugins { ... }' DSL if they specify explicit versions, even if the versions are equal.
Please add the Kotlin plugin to the common parent project or the root project, then remove the versions in the subprojects.
If the parent project does not need the plugin, add 'apply false' to the plugin line.
See: https://docs.gradle.org/current/userguide/plugins.html#sec:subprojects_plugins_dsl
The Kotlin plugin was loaded in the following projects: ':base', ':gradle'

which can be fixed by apply false for the Kotlin plugin in the root project and apply them in the modules where it's needed

Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mrjameshamilton mrjameshamilton merged commit f5f2f06 into Guardsquare:master May 27, 2024
7 checks passed
@mrjameshamilton
Copy link
Collaborator

Thanks @ellet0 !

@EchoEllet
Copy link
Contributor Author

Thanks @ellet0 !

Thank you too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants