Merge pull request #142 from Groww/fix/dom-invalid-props

limited dom-prop injection to only the valid ones
Groww-OSS · Feb 15, 2023 · b4c291b · b4c291b
2 parents dd9fe22 + c9f369a
commit b4c291b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/packages/ui-toolkit/package.json b/packages/ui-toolkit/package.json
@@ -124,4 +124,4 @@
     "lodash.debounce": "^4.0.8",
     "react-waypoint": "^10.1.0"
   }
-}
+}
diff --git a/packages/ui-toolkit/src/components/atoms/Accordion/Accordion.tsx b/packages/ui-toolkit/src/components/atoms/Accordion/Accordion.tsx
@@ -156,7 +156,8 @@ const MutableAccordion = (props: Props) => {
         : <div style={
           {
             ...childStyle,
-            display: 'grid' // to ensure margin is included in the height of the parent container, flex has some issues.
+            display: 'grid', // to ensure margin is included in the height of the parent container, flex has some issues.,
+            gridTemplateColumns: '100%' // to ensure no overflow in x direction
           }
         }
         className={childClass}

diff --git a/packages/ui-toolkit/src/components/atoms/Accordion/AnimateHeight/animateHeightUtils.ts b/packages/ui-toolkit/src/components/atoms/Accordion/AnimateHeight/animateHeightUtils.ts
@@ -22,7 +22,17 @@ export const PROPS_TO_OMIT = [
   'easing',
   'height',
   'onAnimationEnd',
-  'onAnimationStart'
+  'onAnimationStart',
+  'onMountOpen',
+  'showRightIcon',
+  'parentClass',
+  'headerClass',
+  'iconClass',
+  'titleClass',
+  'useAnimateHeight',
+  'mutable',
+  'onToggleCallback',
+  'maxHeight'
 ];
-Original file line number
+Diff line change
@@ Expand Up / @@ -124,4 +124,4 @@ @@
         "lodash.debounce": "^4.0.8",
         "react-waypoint": "^10.1.0"
       }
-    }
+    }