fix type narrowing issue in isEmpty function

close #129
Groww-OSS · Oct 6, 2022 · b1ae728 · b1ae728
1 parent 42c8d6e
commit b1ae728
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/packages/ella/src/general/index.ts b/packages/ella/src/general/index.ts
@@ -5,9 +5,11 @@
 import { dispatchCustomEvent } from '../dom';
 import { CUSTOM_EVENTS } from '../utils/constants';
 import {
+  Empty,
   GenericArguments,
   GenericFunction,
   MultiLevelObject,
+  PickEmptyType,
   SingleLevelObject,
   TabsData
 } from '../utils/types';
@@ -27,7 +29,8 @@ export { default as isEqual } from 'lodash.isequal';
  * }
  * ```
  */
-export function isEmpty(data: any) {
+export function isEmpty<T extends any>(data: T | Empty): data is PickEmptyType<T> {
+
   try {
     if (data === null || data === undefined || typeof data === 'undefined') {
       return true;
@@ -38,7 +41,7 @@ export function isEmpty(data: any) {
     switch (dataType) {
 
       case 'string':
-        if (data.trim() === '' || data === 'null' || data === null) {
+        if ((data as string).trim() === '' || (data as string) === 'null' || data === null) {
           return true;
         }
 

diff --git a/packages/ella/src/utils/types/index.ts b/packages/ella/src/utils/types/index.ts
@@ -66,3 +66,21 @@ export type TabsData = {
   searchId: string;
   [key:string]: unknown;
 };
+
+
+// isEmpty function
+
+export type AllowedValueType = string | number | Array<any> | object | null | undefined | Symbol;
+
+export type Empty =
+  | never[]
+  | Record<keyof any, never>
+  | ''
+  | null
+  | undefined
+  | never;
+
+export type PickEmptyType<T> =
+      T extends AllowedValueType
+        ? Empty
+        : T;