Scores calculation feature #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set button is clicked
iamwatchdogs
requested changes
Oct 31, 2023
iamwatchdogs
requested changes
Oct 31, 2023
| @@ -34,7 +35,7 @@ Hey there, fellow developer !!!... I'm happy to see you are interested in contri | |||
| > [!IMPORTANT] | |||
| > Make sure to check the [CONTRIBUTING.md](https://github.com/Grow-with-Open-Source/Javascript-Projects/blob/main/CONTRIBUTING.md "goto CONTRIBUTING.md") to understand the rules, file structure and step-by-step guide for contribution. | |||
|
|
|||
| - **Step 1:** Make sure you have required tools within you local machine *(like *git, vs code, node.js and so on)*. | |||
| - **Step 1:** Make sure you have the required tools within you local machine *(like *git, vs code, node.js and so on)*. | |||
There was a problem hiding this comment.
Please remove the the from the sentence from line no.38 of the README.md file.
Suggested change
| - **Step 1:** Make sure you have the required tools within you local machine *(like *git, vs code, node.js and so on)*. | |
| - **Step 1:** Make sure you have required tools within you local machine *(like *git, vs code, node.js and so on)*. |
|
I have deleted the branchSent from my Huawei phone-------- Original message --------From: Shamith ***@***.***>Date: Tue, 31 Oct 2023, 3:17 pmTo: Grow-with-Open-Source/Javascript-Projects ***@***.***>Cc: Rohimat Mustapha ***@***.***>, Assign ***@***.***>Subject: Re: [Grow-with-Open-Source/Javascript-Projects] Scores calculation feature (PR #22)
@iamwatchdogs requested changes on this pull request.
You have removed previously made changes but not all of them. Please make the requested changes.
In README.md:
@@ -19,7 +19,8 @@
</div>
-Welcome to **Javascript-Projects**, one of the best ways to introduce the world of open-source contribution! Whether you're a beginner looking to take your first steps or an intermediate developer seeking to refine your skills, this repository is designed to make your journey into open-source development. This repo will provide with best hands-on understanding of open source contributions.
+Welcome to **Javascript-Projects**, one of the best ways to introduce the world of open-source contribution! Whether you're a beginner looking to take your first steps or an intermediate developer seeking to refine your skills, this repository is designed to make your journey into open-source development. This repo will provide you with best hands-on understanding of open source contributions.
+
Please remove the new line on line no.23 of the README.md file.
⬇️ Suggested change
-
In README.md:
@@ -34,7 +35,7 @@ Hey there, fellow developer !!!... I'm happy to see you are interested in contri
[!IMPORTANT]
Make sure to check the [CONTRIBUTING.md](https://github.com/Grow-with-Open-Source/Javascript-Projects/blob/main/CONTRIBUTING.md "goto CONTRIBUTING.md") to understand the rules, file structure and step-by-step guide for contribution.
…-- **Step 1:** Make sure you have required tools within you local machine *(like *git, vs code, node.js and so on)*.
+- **Step 1:** Make sure you have the required tools within you local machine *(like *git, vs code, node.js and so on)*.
Please remove the the from the sentence from line no.38 of the README.md file.
⬇️ Suggested change
-- **Step 1:** Make sure you have the required tools within you local machine *(like *git, vs code, node.js and so on)*.
+- **Step 1:** Make sure you have required tools within you local machine *(like *git, vs code, node.js and so on)*.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: ***@***.***>
|
|
@HeemahMuslad Please make the requested changes and please text something more understandable. |
iamwatchdogs
requested changes
Oct 31, 2023
| @@ -19,8 +19,7 @@ | |||
|
|
|||
| </div> | |||
|
|
|||
| Welcome to **Javascript-Projects**, one of the best ways to introduce the world of open-source contribution! Whether you're a beginner looking to take your first steps or an intermediate developer seeking to refine your skills, this repository is designed to make your journey into open-source development. This repo will provide with best hands-on understanding of open source contributions. | |||
|
|
|||
| Welcome to **Javascript-Projects**, one of the best ways to introduce the world of open-source contribution! Whether you're a beginner looking to take your first steps or an intermediate developer seeking to refine your skills, this repository is designed to make your journey into open-source development. This repo will provide you with best hands-on understanding of open source contributions. | |||
There was a problem hiding this comment.
Please update the previous content.
Suggested change
| Welcome to **Javascript-Projects**, one of the best ways to introduce the world of open-source contribution! Whether you're a beginner looking to take your first steps or an intermediate developer seeking to refine your skills, this repository is designed to make your journey into open-source development. This repo will provide you with best hands-on understanding of open source contributions. | |
| Welcome to **Javascript-Projects**, one of the best ways to introduce the world of open-source contribution! Whether you're a beginner looking to take your first steps or an intermediate developer seeking to refine your skills, this repository is designed to make your journey into open-source development. This repo will provide with best hands-on understanding of open source contributions. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.