ActionSheet + new Examples.. #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUIActionSheet and option to see tabbar example
|
@khoogheem, I like this PR, and will merge, but I have a few issues with the code. For one, I don't like that we have re-defined SYSTEM_VERSION_EQUAL_TO all over the place. Let's put these in a constants.h file, and just include that where we need it. You will see when you update the code, I have added the flat icons to the project as well, so you can create a tab for those if you'd like! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FUIActionSheet and option to see tab bar example....
response to issue #99