Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measurement units, methods #399

Open
atherdon opened this issue May 15, 2019 · 5 comments
Open

measurement units, methods #399

atherdon opened this issue May 15, 2019 · 5 comments
Assignees

Comments

@atherdon
Copy link
Member

atherdon commented May 15, 2019

Right now is blocked by Food-Static-Data/sd#337

Expected Behavior / Situation

Second part of #373

  1. When Eugene will deploy latest changes to fetch, you will be able to connect to that files(that you worked before).
    As you saw that all files for measurements. And you see a similarities.
  2. I want to merge all that files together into one big object. So later we will be able to use it at our servers. This will be our first task.
  3. Extract data from that measurements files and merge into one entity.
    Then we will create some sort of an array/method, so we will be able to filter that data by different "keywords".
    For example, create a separated method, that will display only gallon, or only cooking times from that object.
  4. Later, we will change structures of that big, complex object. Some of our data have not an ideal structure inside.
    Like -> we have integers and string at one field. This is not best solution. Not easy to manage, operate.
    Usually if we will multiply numbers together. So for this current case - it's better to separate data.
    So here, we will create a method, with a few loops -> then get data from a few fields and split them into pieces.

Actual Behavior / Situation

Modification Proposal

@atherdon atherdon changed the title measurement units, methods measurement units, methods [Blocked] May 22, 2019
@atherdon atherdon changed the title measurement units, methods [Blocked] measurement units, methods May 23, 2019
@atherdon
Copy link
Member Author

We can start to work on this task as well. new changes from static data module was moved into this repository. Please sync your fork and re-install packages

@atherdon
Copy link
Member Author

atherdon commented Jun 7, 2019

Let's try to crack this one. but buzz me if something goes wrong. the main reason - this module is not actively updating right now and with latest changes that Eugene did - i expect that a lot of previously created methods can be broken. It might not affect your code, but if anything will generate an error - open a PR and we'll see what it causes

@Beni03
Copy link
Contributor

Beni03 commented Jun 7, 2019 via email

@Beni03
Copy link
Contributor

Beni03 commented Jun 10, 2019

While syncing my fork, I am getting this conflict message. Can I know how to solve this please!
Also I am confused now because, even though, I cloned it locally form https://github.com/Beni03/groceristar-fetch.git, my local files are different from my forked repository.

Thanks
git screen

@atherdon
Copy link
Member Author

ok, don't worry about it right now. it's because of latest changes that was done by Eugene.
Let's switch into sd repo again - while I'll figure out how to solve this issue. will create a task for you there right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants