Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measurements methods #512

Closed
atherdon opened this issue Jun 11, 2019 · 7 comments
Closed

measurements methods #512

atherdon opened this issue Jun 11, 2019 · 7 comments
Assignees

Comments

@atherdon
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I think that we should try to do task from fetch here. I'm talking about GroceriStar/groceristar-fetch#399
And I think we can firstly do it here - because it's a main reason why we have files - and then we'll move it to the fetch plugin

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Beni03
Copy link
Contributor

Beni03 commented Jun 17, 2019

Hi Arthur,
I was trying to understand this task, but I am not very clear of what I should do.

  1. In SD repo, we already have filesObjects.js and I think it has all those files in to one object right?
  2. What are measurement files? all json files inside data folder?
    Can you please give me some more details to understand this task
    Thanks

@atherdon
Copy link
Contributor Author

atherdon commented Jun 18, 2019 via email

@Beni03
Copy link
Contributor

Beni03 commented Jun 18, 2019

Got it! thanks

@Beni03 Beni03 mentioned this issue Jun 20, 2019
14 tasks
@atherdon
Copy link
Contributor Author

Can you create few simple methods, that will use functionality that you did in prev PR and return measurements files to the outside?

also, next move can be to combine few files that have objects into one big object

we have this code, but i don't remember how it actually works
https://github.com/GroceriStar/sd/blob/master/generator/generateArray.js#L106-L140
can you take a look and figure it out?

@Beni03
Copy link
Contributor

Beni03 commented Jun 27, 2019 via email

@Beni03 Beni03 mentioned this issue Jul 10, 2019
14 tasks
@atherdon
Copy link
Contributor Author

ok, closing it.
Do you have another task or i should create a new one for you?

@Beni03
Copy link
Contributor

Beni03 commented Jul 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants