-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
measurements methods #512
Comments
Hi Arthur,
|
1) yes
2) we have 2 files related to measurement system. it's called measurement
system and measurement units. right now they're separated. when you'll do
this task, later we'll work on merging them into one structure
… |
Got it! thanks |
Can you create few simple methods, that will use functionality that you did in prev PR and return measurements files to the outside? also, next move can be to combine few files that have objects into one big object we have this code, but i don't remember how it actually works |
Yes I’ll try to do this
…Sent from my iPhone
On Jun 26, 2019, at 3:48 PM, Arthur Tkachenko ***@***.***> wrote:
Can you create few simple methods, that will use functionality that you did in prev PR and return measurements files to the outside?
also, next move can be to combine few files that have objects into one big object
we have this code, but i don't remember how it actually works
https://github.com/GroceriStar/sd/blob/master/generator/generateArray.js#L106-L140
can you take a look and figure it out?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
ok, closing it. |
Is your feature request related to a problem? Please describe.
I think that we should try to do task from fetch here. I'm talking about GroceriStar/groceristar-fetch#399
And I think we can firstly do it here - because it's a main reason why we have files - and then we'll move it to the fetch plugin
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: