Fix thread exception when accessing bukkit methods from netty threads #2003
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axionize
force-pushed
the
fix/resetBukkitItemUsage-threading-illegal-state-exception
branch
from
528e57c to
4b391e4
Compare
Axionize
force-pushed
the
fix/resetBukkitItemUsage-threading-illegal-state-exception
branch
from
4b391e4 to
b8da39c
Compare
|
I want to avoid |
|
Sorry I don't follow, I'm not sure what you're talking about |
|
Look at the scoreboard 2025-02-10.15-43-12.mp4 |
|
@ManInMyVan yea but you can't update the player's inventory on the netty thread regardless |
We can just send a packet to the server on behalf of the player to sync the inventory state? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ManInMyVan not sure what happened when you said you were fixing the exception from calling on the netty thread, your commit to fix this did not because you aren't running in the right thread.