-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M major refactor #760
base: master
Are you sure you want to change the base?
M major refactor #760
Commits on Sep 26, 2017
-
Short, James authored and Short, James committed
Sep 26, 2017 Configuration menu - View commit details
-
Copy full SHA for 89ecac2 - Browse repository at this point
Copy the full SHA 89ecac2View commit details
Commits on Oct 5, 2017
-
Refactored the selector composing function into a utils class, added …
…a composable selector generator function to be used to create composable selectors.
Short, James authored and Short, James committedOct 5, 2017 Configuration menu - View commit details
-
Copy full SHA for 5fca14d - Browse repository at this point
Copy the full SHA 5fca14dView commit details
Commits on Oct 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for bf2f54e - Browse repository at this point
Copy the full SHA bf2f54eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc770f6 - Browse repository at this point
Copy the full SHA bc770f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2c97c8 - Browse repository at this point
Copy the full SHA d2c97c8View commit details
Commits on Oct 12, 2017
-
Compose enhancers instead of overriding them
Lis, Scott authored and Short, James committedOct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 4089fad - Browse repository at this point
Copy the full SHA 4089fadView commit details -
Short, James authored and Short, James committed
Oct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 2c6e610 - Browse repository at this point
Copy the full SHA 2c6e610View commit details -
Short, James authored and Short, James committed
Oct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for a04c699 - Browse repository at this point
Copy the full SHA a04c699View commit details -
Move selectors on context change to its own branch
Short, James authored and Short, James committedOct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 0567dfc - Browse repository at this point
Copy the full SHA 0567dfcView commit details -
Merge branch 'master' into m-composable-selectors
* master: Use Loading component when data={null|undefined} Handle data={null|undefined} Wire up Redux DevTools
Short, James authored and Short, James committedOct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 8db33e1 - Browse repository at this point
Copy the full SHA 8db33e1View commit details -
add dataLoadingSelector to composedSelectors
Short, James authored and Short, James committedOct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 8f9c74c - Browse repository at this point
Copy the full SHA 8f9c74cView commit details -
Small changes to TableContainer
Short, James authored and Short, James committedOct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for ea0e50c - Browse repository at this point
Copy the full SHA ea0e50cView commit details -
Short, James authored and Short, James committed
Oct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 6da06fa - Browse repository at this point
Copy the full SHA 6da06faView commit details -
Add actions to the context. Use the simple later plugins override met…
…hod for now.
Short, James authored and Short, James committedOct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 8805225 - Browse repository at this point
Copy the full SHA 8805225View commit details -
Merge branch 'm-actions-on-context' into m-selectors-actions-on-context
* m-actions-on-context: Add actions to the context. Use the simple later plugins override method for now.
Short, James authored and Short, James committedOct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for f37d2d0 - Browse repository at this point
Copy the full SHA f37d2d0View commit details -
Removed hard references to actions in the core code, deleted commente…
…d imports of selectors and moved import statements of any Griddle code to be separated from module imports
Short, James authored and Short, James committedOct 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 983375d - Browse repository at this point
Copy the full SHA 983375dView commit details
Commits on Oct 13, 2017
-
Merge branch 'refactor-743' into m-composable-selectors-refactor
* refactor-743: Convert existing selectors to dynamic dependency resolution Composable selectors Also refactors on top of refactor-743
Short, James authored and Short, James committedOct 13, 2017 Configuration menu - View commit details
-
Copy full SHA for 6366eaa - Browse repository at this point
Copy the full SHA 6366eaaView commit details -
First pass at moving 'core' code into a plugin. Stories seem to be wo…
…rking fine with this code. Going to pull a lot of the 'core' specific stuff into that plugin so that the initialization phase has no dependencies on its specific structure.
Short, James authored and Short, James committedOct 13, 2017 Configuration menu - View commit details
-
Copy full SHA for f1fa4dd - Browse repository at this point
Copy the full SHA f1fa4ddView commit details
Commits on Oct 16, 2017
-
Most of the stuff associated with the 'core' plugin in src/index.js h…
…as been moved out. There are still some lingering bits to do with the redux state I would like to fix but they need selector refactors.
Short, James authored and Short, James committedOct 16, 2017 Configuration menu - View commit details
-
Copy full SHA for 1ce5b57 - Browse repository at this point
Copy the full SHA 1ce5b57View commit details
Commits on Oct 17, 2017
-
Merge branch 'm-baseline-plugin' into m-major-refactor
* m-baseline-plugin: Most of the stuff associated with the 'core' plugin in src/index.js has been moved out. There are still some lingering bits to do with the redux state I would like to fix but they need selector refactors. First pass at moving 'core' code into a plugin. Stories seem to be working fine with this code. Going to pull a lot of the 'core' specific stuff into that plugin so that the initialization phase has no dependencies on its specific structure. # Conflicts: # src/index.js
Short, James authored and Short, James committedOct 17, 2017 Configuration menu - View commit details
-
Copy full SHA for b251237 - Browse repository at this point
Copy the full SHA b251237View commit details -
Merge branch 'm-composable-selectors-refactor' into m-major-refactor
* m-composable-selectors-refactor: Complete example story add dataLoadingSelector to composedSelectors Refactor and add story Convert existing selectors to dynamic dependency resolution Composable selectors Refactored the selector composing function into a utils class, added a composable selector generator function to be used to create composable selectors. Composable selectors # Conflicts: # src/index.js # src/plugins/core/selectors/dataSelectors.js
Short, James authored and Short, James committedOct 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 02bc079 - Browse repository at this point
Copy the full SHA 02bc079View commit details -
Merge branch 'm-selectors-actions-on-context' into m-major-refactor
* m-selectors-actions-on-context: Removed hard references to actions in the core code, deleted commented imports of selectors and moved import statements of any Griddle code to be separated from module imports Add actions to the context. Use the simple later plugins override method for now. Small changes to TableContainer Move selectors on context change to its own branch # Conflicts: # src/index.js # src/plugins/core/components/CellContainer.js # src/plugins/core/components/FilterContainer.js # src/plugins/core/components/LayoutContainer.js # src/plugins/core/components/LoadingContainer.js # src/plugins/core/components/NextButtonContainer.js # src/plugins/core/components/NextButtonEnhancer.js # src/plugins/core/components/NoResultsContainer.js # src/plugins/core/components/PageDropdownContainer.js # src/plugins/core/components/PaginationContainer.js # src/plugins/core/components/PreviousButtonContainer.js # src/plugins/core/components/PreviousButtonEnhancer.js # src/plugins/core/components/RowContainer.js # src/plugins/core/components/SettingsContainer.js # src/plugins/core/components/SettingsToggleContainer.js # src/plugins/core/components/SettingsWrapperContainer.js # src/plugins/core/components/TableBodyContainer.js # src/plugins/core/components/TableContainer.js # src/plugins/core/components/TableHeadingCellContainer.js # src/plugins/core/components/TableHeadingCellEnhancer.js # src/plugins/core/components/TableHeadingContainer.js
Short, James authored and Short, James committedOct 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 334a68b - Browse repository at this point
Copy the full SHA 334a68bView commit details -
Merge branch 'm-composable-enhancers' into m-major-refactor
* m-composable-enhancers: Roll back some changes Compose enhancers instead of overriding them
Short, James authored and Short, James committedOct 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 2567ded - Browse repository at this point
Copy the full SHA 2567dedView commit details -
Updated store listener code to use the most current store state as it…
…s 'beginning' oldState instead of undefined, updated the core GRIDDLE_UPDATE_STATE reducer to not attempt a change on data if it is undefined. This may warrant some further looking at. Also updated the story for overridable selectors so that it should be working fine now.
Short, James authored and Short, James committedOct 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 0d510aa - Browse repository at this point
Copy the full SHA 0d510aaView commit details
Commits on Oct 19, 2017
-
Fixed core, local, and position plugin tests to work with new selecto…
…rs and directory structure. Selectors now have a factory prop that can build copies of this selector.
Short, James authored and Short, James committedOct 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 28cc4ff - Browse repository at this point
Copy the full SHA 28cc4ffView commit details