Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M major refactor #760

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Commits on Sep 26, 2017

  1. Composable selectors

    Short, James authored and Short, James committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    89ecac2 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2017

  1. Refactored the selector composing function into a utils class, added …

    …a composable selector generator function to be used to create composable selectors.
    Short, James authored and Short, James committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    5fca14d View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2017

  1. Composable selectors

    Short, James authored and dahlbyk committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    bf2f54e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc770f6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d2c97c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2017

  1. Compose enhancers instead of overriding them

    Lis, Scott authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    4089fad View commit details
    Browse the repository at this point in the history
  2. Roll back some changes

    Short, James authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    2c6e610 View commit details
    Browse the repository at this point in the history
  3. Refactor and add story

    Short, James authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    a04c699 View commit details
    Browse the repository at this point in the history
  4. Move selectors on context change to its own branch

    Short, James authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    0567dfc View commit details
    Browse the repository at this point in the history
  5. Merge branch 'master' into m-composable-selectors

    * master:
      Use Loading component when data={null|undefined}
      Handle data={null|undefined}
      Wire up Redux DevTools
    Short, James authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    8db33e1 View commit details
    Browse the repository at this point in the history
  6. add dataLoadingSelector to composedSelectors

    Short, James authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    8f9c74c View commit details
    Browse the repository at this point in the history
  7. Small changes to TableContainer

    Short, James authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    ea0e50c View commit details
    Browse the repository at this point in the history
  8. Complete example story

    Short, James authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    6da06fa View commit details
    Browse the repository at this point in the history
  9. Add actions to the context. Use the simple later plugins override met…

    …hod for now.
    Short, James authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    8805225 View commit details
    Browse the repository at this point in the history
  10. Merge branch 'm-actions-on-context' into m-selectors-actions-on-context

    * m-actions-on-context:
      Add actions to the context. Use the simple later plugins override method for now.
    Short, James authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    f37d2d0 View commit details
    Browse the repository at this point in the history
  11. Removed hard references to actions in the core code, deleted commente…

    …d imports of selectors and moved import statements of any Griddle code to be separated from module imports
    Short, James authored and Short, James committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    983375d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2017

  1. Merge branch 'refactor-743' into m-composable-selectors-refactor

    * refactor-743:
      Convert existing selectors to dynamic dependency resolution
      Composable selectors
    
    Also refactors on top of refactor-743
    Short, James authored and Short, James committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    6366eaa View commit details
    Browse the repository at this point in the history
  2. First pass at moving 'core' code into a plugin. Stories seem to be wo…

    …rking fine with this code. Going to pull a lot of the 'core' specific stuff into that plugin so that the initialization phase has no dependencies on its specific structure.
    Short, James authored and Short, James committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    f1fa4dd View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2017

  1. Most of the stuff associated with the 'core' plugin in src/index.js h…

    …as been moved out. There are still some lingering bits to do with the redux state I would like to fix but they need selector refactors.
    Short, James authored and Short, James committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    1ce5b57 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2017

  1. Merge branch 'm-baseline-plugin' into m-major-refactor

    * m-baseline-plugin:
      Most of the stuff associated with the 'core' plugin in src/index.js has been moved out. There are still some lingering bits to do with the redux state I would like to fix but they need selector refactors.
      First pass at moving 'core' code into a plugin. Stories seem to be working fine with this code. Going to pull a lot of the 'core' specific stuff into that plugin so that the initialization phase has no dependencies on its specific structure.
    
    # Conflicts:
    #	src/index.js
    Short, James authored and Short, James committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    b251237 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'm-composable-selectors-refactor' into m-major-refactor

    * m-composable-selectors-refactor:
      Complete example story
      add dataLoadingSelector to composedSelectors
      Refactor and add story
      Convert existing selectors to dynamic dependency resolution
      Composable selectors
      Refactored the selector composing function into a utils class, added a composable selector generator function to be used to create composable selectors.
      Composable selectors
    
    # Conflicts:
    #	src/index.js
    #	src/plugins/core/selectors/dataSelectors.js
    Short, James authored and Short, James committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    02bc079 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'm-selectors-actions-on-context' into m-major-refactor

    * m-selectors-actions-on-context:
      Removed hard references to actions in the core code, deleted commented imports of selectors and moved import statements of any Griddle code to be separated from module imports
      Add actions to the context. Use the simple later plugins override method for now.
      Small changes to TableContainer
      Move selectors on context change to its own branch
    
    # Conflicts:
    #	src/index.js
    #	src/plugins/core/components/CellContainer.js
    #	src/plugins/core/components/FilterContainer.js
    #	src/plugins/core/components/LayoutContainer.js
    #	src/plugins/core/components/LoadingContainer.js
    #	src/plugins/core/components/NextButtonContainer.js
    #	src/plugins/core/components/NextButtonEnhancer.js
    #	src/plugins/core/components/NoResultsContainer.js
    #	src/plugins/core/components/PageDropdownContainer.js
    #	src/plugins/core/components/PaginationContainer.js
    #	src/plugins/core/components/PreviousButtonContainer.js
    #	src/plugins/core/components/PreviousButtonEnhancer.js
    #	src/plugins/core/components/RowContainer.js
    #	src/plugins/core/components/SettingsContainer.js
    #	src/plugins/core/components/SettingsToggleContainer.js
    #	src/plugins/core/components/SettingsWrapperContainer.js
    #	src/plugins/core/components/TableBodyContainer.js
    #	src/plugins/core/components/TableContainer.js
    #	src/plugins/core/components/TableHeadingCellContainer.js
    #	src/plugins/core/components/TableHeadingCellEnhancer.js
    #	src/plugins/core/components/TableHeadingContainer.js
    Short, James authored and Short, James committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    334a68b View commit details
    Browse the repository at this point in the history
  4. Merge branch 'm-composable-enhancers' into m-major-refactor

    * m-composable-enhancers:
      Roll back some changes
      Compose enhancers instead of overriding them
    Short, James authored and Short, James committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    2567ded View commit details
    Browse the repository at this point in the history
  5. Updated store listener code to use the most current store state as it…

    …s 'beginning' oldState instead of undefined, updated the core GRIDDLE_UPDATE_STATE reducer to not attempt a change on data if it is undefined. This may warrant some further looking at. Also updated the story for overridable selectors so that it should be working fine now.
    Short, James authored and Short, James committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    0d510aa View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2017

  1. Fixed core, local, and position plugin tests to work with new selecto…

    …rs and directory structure. Selectors now have a factory prop that can build copies of this selector.
    Short, James authored and Short, James committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    28cc4ff View commit details
    Browse the repository at this point in the history