refactor[cartesian]: gt4py/dace bridge cleanup #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the oir -> dace lowering (the one with the unexpanded library nodes, don't use the generic visit function. Instead, visit the vertical loops directly.
Add a bit more information to the library node name. This facilitates debugging in that it is easier to associate the orgininal vertical loops with the nodes.
- Import is unused - Comments are redundant with doc strings
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for PR #1894, pull out some refactors and cleanups. Notable in this PR are the changes to
src/gt4py/cartesian/gtc/dace/oir_to_dace.pystencil.vertical_loopsdirectly instead of callinggeneric_visit(simplification since there's nothing else to visit)f"{sdfg_name}_computation_{id(node)}"tof"{sdfg_name}_vloop_{counter}_{node.loop_order}_{id(node)}". This adds a bit more information (becausesdfg_nameis the same for all library nodes) and thus simplifies debugging workflows.Related issue: GEOS-ESM/NDSL#53
Requirements
covered by existing test suite
N/A