Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build[cartesian][next]: Bump dace version from 0.14.4 to 0.15.1 #1391

Merged
merged 27 commits into from
Jan 19, 2024
Merged

build[cartesian][next]: Bump dace version from 0.14.4 to 0.15.1 #1391

merged 27 commits into from
Jan 19, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Dec 11, 2023 •
edited
Loading

Description

Bumping dace version to 0.15.1 affects both cartesian and next gt4py:

  • cartesian: removed try/except for dace backward compatibility
  • next: re-enabled some tests that were broken on dace 0.15
  • all: fixed and/or suppressed flake8 errors

@edopao edopao changed the title feat[build]: Bump dace version from 0.14.4 to 0.15.1 build[cartesian][next]: Bump dace version from 0.14.4 to 0.15.1 Dec 11, 2023
@edopao edopao closed this Dec 11, 2023
@edopao edopao reopened this Dec 13, 2023
havogt
havogt reviewed Dec 13, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@edopao
Copy link
Contributor Author

edopao commented Dec 14, 2023 •
edited
Loading

The cause of the failures in the cartesian tests seems to be that the generate SDFG is not valid, tracked as a DaCe issue: spcl/dace#1486

It was working with dace v0.14.4, but v0.15.1 is no longer able to deal with it. It seems that v0.15.1 does more analysis and transformations on indirection tasklets but, in order to do this, more stringent conditions are required on array access inside tasklets.

@edopao edopao marked this pull request as ready for review January 17, 2024 16:07
@edopao edopao requested a review from havogt January 18, 2024 07:22
havogt
havogt requested changes Jan 18, 2024
View reviewed changes
src/gt4py/eve/datamodels/core.py Outdated Show resolved Hide resolved
src/gt4py/next/otf/workflow.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py Outdated Show resolved Hide resolved
src/gt4py/eve/utils.py Outdated Show resolved Hide resolved
src/gt4py/eve/utils.py Outdated Show resolved Hide resolved
src/gt4py/next/common.py Show resolved Hide resolved
@edopao edopao requested a review from havogt January 18, 2024 15:32
havogt
havogt approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the typing fix, see comment. Otherwise looks good.

@edopao edopao merged commit b900b47 into GridTools:main Jan 19, 2024
36 checks passed
@edopao edopao deleted the dace-next branch January 19, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havogt havogt havogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edopao @havogt