Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[cartesian]: DaceIR bridge for DaCe v0.15 #1373

Merged

Conversation

FlorianDeconinck
Copy link
Contributor

Description

Going to the next major version of DaCe (v15) has led a couple of breakage.
The current codegen used a static naming for state struct. The default has changed and an option has been introduce in the dace config, we replicate those changes here.
Missing DaCe schedule to GT4Py schedule mapping.

Those changes will not affect next.
Those changes were tested internally at NASA on the GEOS model.

Copy link
Contributor

@gronerl gronerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to fix squashed commit message to say v0.15, e.g. by fixing PR title (would make looking for the commit easier later).

src/gt4py/cartesian/backend/dace_backend.py Outdated Show resolved Hide resolved
@havogt
Copy link
Contributor

havogt commented Nov 29, 2023

cscs-ci run

@FlorianDeconinck FlorianDeconinck changed the title fix[cartesian]: DaceIR bridge for DaCe v15+ fix[cartesian]: DaceIR bridge for DaCe v15.0 Nov 29, 2023
@FlorianDeconinck FlorianDeconinck changed the title fix[cartesian]: DaceIR bridge for DaCe v15.0 fix[cartesian]: DaceIR bridge for DaCe v0.15 Nov 29, 2023
@havogt
Copy link
Contributor

havogt commented Nov 30, 2023

cscs-ci run

@FlorianDeconinck FlorianDeconinck merged commit 6e13354 into GridTools:main Nov 30, 2023
24 checks passed
@FlorianDeconinck FlorianDeconinck deleted the cartesian/dace_bridge_v15 branch November 30, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants