Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16 setup benchmarking infrastructure #24

Open
wants to merge 54 commits into
base: main
Choose a base branch
from

Conversation

lorenzovarese
Copy link
Collaborator

@lorenzovarese lorenzovarese commented Jul 18, 2024

#16

  • Separate in different modules the mesh definitions in order to retrieve them in benchmarks
  • Create a generic suite of benchmarks in benchmark/benchmarks.jl
  • Create a specific suite for advection in benchmark/benchmarks_advection.jl
  • Make the suite compatible with AirspeedVelocity and document the usage of AirspeedVelocity on the README.md of the benchmark folder.

@lorenzovarese lorenzovarese self-assigned this Jul 18, 2024
@lorenzovarese lorenzovarese linked an issue Jul 18, 2024 that may be closed by this pull request
2 tasks
@lorenzovarese lorenzovarese marked this pull request as draft July 18, 2024 14:06
@lorenzovarese lorenzovarese marked this pull request as ready for review July 18, 2024 14:06
@lorenzovarese lorenzovarese marked this pull request as draft July 18, 2024 14:06
@lorenzovarese lorenzovarese added the enhancement New feature or request label Aug 20, 2024
@lorenzovarese lorenzovarese marked this pull request as ready for review August 20, 2024 15:53
@lorenzovarese
Copy link
Collaborator Author

lorenzovarese commented Aug 20, 2024

@tehrengruber
Main changes:

  • Split the benchmarks into two parts/files:

    1. benchmark.jl: includes all the benchmarks for broadcast cases, trigonometric functions, neighbor sum, and remapping.
    2. benchmark_advection.jl: contains all (supported) benchmarks for advection, including the Upwind scheme for both embedded and Python backends, and the Mpdata program, embedded only.
  • The benchmarks are supported by running them directly or using the AirspeedVelocity package. I have added a README.md to the benchmark folder that contains additional instructions useful for running the benchmarks.

  • Some modifications that were left from issue Improve Atlas #15 are now implemented here. This includes the separation of the simulation loop from the advection setup of the miniapp and the creation of a new module for AtlasMeshes.

There are no optimizations present in this branch. The objective is to merge this into the origin and then tag the merge commit as a baseline for all other optimizations.

P.s. the plot is working. After running the benchmark with benchpkg you can generate easily the plot with the command benchpkgplot. Here a basic example on two commits:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Benchmarking Infrastructure
1 participant