Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15 improve atlas #23

Merged
merged 18 commits into from
Aug 16, 2024
Merged

15 improve atlas #23

merged 18 commits into from
Aug 16, 2024

Conversation

lorenzovarese
Copy link
Collaborator

Closes #15

@lorenzovarese lorenzovarese added the enhancement New feature or request label Jul 18, 2024
@lorenzovarese lorenzovarese self-assigned this Jul 18, 2024
@lorenzovarese lorenzovarese linked an issue Jul 18, 2024 that may be closed by this pull request
2 tasks
src/examples/advection/README.md Outdated Show resolved Hide resolved
src/examples/advection/advection_example.jl Outdated Show resolved Hide resolved
V2V = FieldOffset("V2V", source = Vertex, target = (Vertex, V2VDim))
E2V = FieldOffset("E2V", source = Vertex, target = (Edge, E2VDim))
V2E = FieldOffset("V2E", source = Edge, target = (Vertex, V2EDim))
Koff = FieldOffset("Koff", source = K, target = K)

include("atlas_mesh.jl")
# Include additional necessary files for mesh, state container, metric calculations, and advection operations
include("../../atlas/atlas_mesh.jl")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be imported with using.

src/examples/advection/advection_example.jl Outdated Show resolved Hide resolved
@lorenzovarese lorenzovarese merged commit c0e954a into main Aug 16, 2024
1 of 4 checks passed
@lorenzovarese lorenzovarese deleted the 15-improve-atlas branch August 16, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Atlas
2 participants