14 laplacian tests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lts with GT4Py backend)
… with the laplacian case
Closed
2 tasks
tehrengruber
requested changes
Jul 22, 2024
test/gt2py_fo_exec.jl
Outdated
| function lap_ground_truth(in_field::Matrix{Float64})::Matrix{Float64} | ||
| nrows, ncols = size(in_field) | ||
| out_field = zeros(Float64, nrows, ncols) # Initialize out_field as a matrix of zeros | ||
| out_field .= in_field # Copy inplace: to keep the initial values in the border |
There was a problem hiding this comment.
Is this required? For simplicity I would simply keep the boundary values zero. Also it feels a little odd to mix the laplacian of some vector with the actual values.
There was a problem hiding this comment.
I included this copy incorrectly thinking of the case where the edge values were to be saved. However, it is better to start with an empty matrix and handle the edge values differently.
However, since the values at the edges are not touched by the Laplacian. For now I can keep the values at zero, but then it will have to be changed to the actual values of the input.
tehrengruber
approved these changes
Jul 24, 2024
Co-authored-by: Till Ehrengruber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14