Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13 refactor tests in gt4py fo execjl #17

Merged
merged 41 commits into from
Jul 17, 2024
Merged

13 refactor tests in gt4py fo execjl #17

merged 41 commits into from
Jul 17, 2024

Conversation

lorenzovarese
Copy link
Collaborator

Closes #13

@lorenzovarese
Ignore virtual env
7ad244a
@lorenzovarese
Add notes for future improvements
2c76bae
@lorenzovarese
Ignore all .DS_Store
f9d9118
@lorenzovarese
Ignore configuration files in the .vscode folder
109e285
@lorenzovarese
Ignore .python-version specified by pyenv
43626a3
@lorenzovarese
Refine .gitignore
95681e1
@lorenzovarese
Add first tests with ground truth
5dcf2db
@lorenzovarese
Separate the setup and the backend selection in the gt2py_fo_exec tests
9f88169
@lorenzovarese
Reformat the code
11e637b
@lorenzovarese
Fix the offset provider of the embedded execution that requires E2CDi…
8c3cbd0 
…m in gt2py_fo_exec
@lorenzovarese
Clean lambda functions in testwrapper
154e571
@lorenzovarese
Add ground truth computation for test_fo_neighbor_sum test
e6f7128
@lorenzovarese
Setup the implementation of the following tests
9cdf9b9
@lorenzovarese
Improve fo_max_over test
6f7fd52
@lorenzovarese
Improve test for min
c6d89c7
@lorenzovarese
Improve test for simple broadcast
7ca03d5
@lorenzovarese
Fix Typos
500d57c
@lorenzovarese
Improve scalar broadcast test
4860562
@lorenzovarese
Fix where example in builtins.jl
d3f9b92
@lorenzovarese
Improve where test
3fcc315
@lorenzovarese
Improve test on field convert (casting)
16f3f89
@lorenzovarese
Improve tests for sin and asinh
4a2aeab
@lorenzovarese
Add documentation to the testwrapper utility function
8e258da
@lorenzovarese
Improve nested field_operator test and clean the missing offset array…
c57646f 
… test
@lorenzovarese
Add notes on offset array
461814f
@lorenzovarese
Cleanup before submission
5a13842
@lorenzovarese lorenzovarese added the enhancement New feature or request label Jul 10, 2024
@lorenzovarese lorenzovarese self-assigned this Jul 10, 2024
tehrengruber
tehrengruber reviewed Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@tehrengruber tehrengruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round.

src/gt2py/gt2py.jl Outdated Show resolved Hide resolved
test/gt2py_fo_exec.jl Outdated Show resolved Hide resolved
test/gt2py_fo_exec.jl Show resolved Hide resolved
test/gt2py_fo_exec.jl Outdated Show resolved Hide resolved
test/gt2py_fo_exec.jl Outdated Show resolved Hide resolved
test/gt2py_fo_exec.jl Outdated Show resolved Hide resolved
test/gt2py_fo_exec.jl Show resolved Hide resolved
lorenzovarese and others added 10 commits July 11, 2024 09:06
tehrengruber
tehrengruber requested changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@tehrengruber tehrengruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last review round I think.

src/GridTools.jl Outdated Show resolved Hide resolved
test/gt2py_fo_exec.jl Outdated Show resolved Hide resolved
test/gt2py_fo_exec.jl Outdated Show resolved Hide resolved
test/gt2py_fo_exec.jl Outdated Show resolved Hide resolved
@lorenzovarese lorenzovarese merged commit 084cf9f into GridTools:main Jul 17, 2024
1 of 3 checks passed
@lorenzovarese lorenzovarese deleted the 13-refactor-tests-in-gt4py_fo_execjl branch July 17, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehrengruber tehrengruber tehrengruber requested changes

Assignees

@lorenzovarese lorenzovarese

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor tests in gt4py_fo_exec.jl
2 participants
@lorenzovarese @tehrengruber