Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16 setup benchmarking infrastructure #24

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

16 setup benchmarking infrastructure #24

wants to merge 54 commits into from

Conversation

lorenzovarese
Copy link
Collaborator

@lorenzovarese lorenzovarese commented Jul 18, 2024 •
edited
Loading

#16

  • Separate in different modules the mesh definitions in order to retrieve them in benchmarks
  • Create a generic suite of benchmarks in benchmark/benchmarks.jl
  • Create a specific suite for advection in benchmark/benchmarks_advection.jl
  • Make the suite compatible with AirspeedVelocity and document the usage of AirspeedVelocity on the README.md of the benchmark folder.

@lorenzovarese lorenzovarese self-assigned this Jul 18, 2024
@lorenzovarese lorenzovarese linked an issue Jul 18, 2024 that may be closed by this pull request
Setup Benchmarking Infrastructure #16
Open
2 tasks
@lorenzovarese lorenzovarese marked this pull request as draft July 18, 2024 14:06
@lorenzovarese lorenzovarese marked this pull request as ready for review July 18, 2024 14:06
@lorenzovarese lorenzovarese marked this pull request as draft July 18, 2024 14:06
lorenzovarese and others added 23 commits July 18, 2024 16:11
@lorenzovarese
Fix pip install gt4py
02ee8b7
@lorenzovarese
Fix PyCall installation in the benchmark_pr.yml
2ae9b77
@lorenzovarese
Fix the PyCall invoke
8686326
@lorenzovarese
Add reference to julia env in benchmark_pr config
e978b6c
@lorenzovarese
Add cache for python, and fix the pycall (again :/)
ea7d32d
@lorenzovarese
Activate the env in the benchmark CI
3d12f85
@lorenzovarese
Include the Cell and K definitions in the benchmark
2ae25f2
@lorenzovarese
Add readme to run benchmark example
5412e44
@lorenzovarese
Add commented benchmark for field operations
978e6b5
@lorenzovarese
Merge remote-tracking branch 'origin' into 16-setup-benchmarking-infr…
49687ce 
…astructure
@lorenzovarese
fix benchmarks
8046538
@lorenzovarese
Add benchmark comparison between Julia's broadcast addition and the f…
8fea0ca 
…ield operator one
@lorenzovarese
Update the Benchmark suite. Provide comparison between broadcast on a…
8d0296b 
…rray, on fields data and with field operator.
@lorenzovarese
Improve naming and type checking
b9d4e2e
@lorenzovarese
Add draft of neighbour_sum benchmark
2ab1421
@lorenzovarese
Add the benchmarks for sine and cosine field operators
3062bdf
@lorenzovarese
Add benchmarks for remapping
323c269
@lorenzovarese
Add draft mpdata
9c138c2
@lorenzovarese
Merge remote-tracking branch 'origin' into 16-setup-benchmarking-infr…
e3ba8ec 
…astructure
@lorenzovarese
Clear benchmarks.jl and add remapping
700a545
@lorenzovarese
Add neighbor sum benchmark to the suite
3590280
@lorenzovarese
Fix dependencies in benchmarks
0be7ec1
@lorenzovarese
Add verbose flag to avoid printing
62276b0
@lorenzovarese
Fix slicing operation in the advection_miniapp
22d1257
@lorenzovarese
Fix benchmarking size
30d92c1
@lorenzovarese
Remove deprecated benchmark files
9928e14
@lorenzovarese
Fix advection benchmarks and place them in a separate script
177f8ba
@lorenzovarese
Fix K dimension in advection meshes
391dc0a
@lorenzovarese
Add multi-threads optimization on broadcasting operation
9048666
@lorenzovarese
Change benchmark SUITE for compatibility with AirSpeedVelocity
e2ce601
@lorenzovarese
Add multi-threads optimization
45cf97a
@lorenzovarese
Merge branch '16-setup-benchmarking-infrastructure' of https://github…
6fb4870 
….com/GridTools/GridTools.jl into 16-setup-benchmarking-infrastructure
@lorenzovarese
Restoring SIMD loop in broadcast
8b8a68f
@lorenzovarese
Add benchmark readme on how to run benchmarks on separate revisions
be385b7
@lorenzovarese
Create an AtlasMeshes module and resolve issues with atlas4py import
b9ebf8e
@lorenzovarese
Fix embedded test with the new K dimension definition in example meshes
085877d
@lorenzovarese
Separate the simulation loop from the Advection Setup of the miniapp
89572e1
@lorenzovarese
Small changes in benchmark documentation
4d71e0b
@lorenzovarese
Fix the names retrieval of the modules automatically generated by Air…
26fe900 
…SpeedVelocity when running the advection benchmark
@lorenzovarese lorenzovarese added the enhancement New feature or request label Aug 20, 2024
@lorenzovarese lorenzovarese marked this pull request as ready for review August 20, 2024 15:53
@lorenzovarese
Copy link
Collaborator Author

lorenzovarese commented Aug 20, 2024 •
edited
Loading

@tehrengruber
Main changes:

  • Split the benchmarks into two parts/files:

    1. benchmark.jl: includes all the benchmarks for broadcast cases, trigonometric functions, neighbor sum, and remapping.
    2. benchmark_advection.jl: contains all (supported) benchmarks for advection, including the Upwind scheme for both embedded and Python backends, and the Mpdata program, embedded only.

  • The benchmarks are supported by running them directly or using the AirspeedVelocity package. I have added a README.md to the benchmark folder that contains additional instructions useful for running the benchmarks.

  • Some modifications that were left from issue Improve Atlas #15 are now implemented here. This includes the separation of the simulation loop from the advection setup of the miniapp and the creation of a new module for AtlasMeshes.

There are no optimizations present in this branch. The objective is to merge this into the origin and then tag the merge commit as a baseline for all other optimizations.

P.s. the plot is working. After running the benchmark with benchpkg you can generate easily the plot with the command benchpkgplot. Here a basic example on two commits:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehrengruber tehrengruber Awaiting requested review from tehrengruber

Assignees

@lorenzovarese lorenzovarese

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup Benchmarking Infrastructure
1 participant
@lorenzovarese