feat: support custom app secret in the setup() call + EVM signTypedData fixes
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi93
force-pushed
the
setup-custom-app-secret
branch
4 times, most recently
from
ce3b76a to
df9cef6
Compare
refi93
changed the title
setup() callsetup() call + EVM signTypedData fixes
refi93
commented
Jul 23, 2024
| @@ -76,7 +76,7 @@ const validateEthereumMsgResponse = function (res, req) { | |||
| const digest = prehash ? prehash : encoded; | |||
| const chainId = parseInt(input.payload.domain.chainId, 16); | |||
| // Get recovery param with a `v` value of [27,28] by setting `useEIP155=false` | |||
| return addRecoveryParam(digest, sig, signer, { chainId }); | |||
| return addRecoveryParam(digest, sig, signer, { chainId, useEIP155: false }); | |||
There was a problem hiding this comment.
as far as I checked on metamask demo app, metamask apparently still returns a non-EIP155 signature of typed data V4 and if I didn't disable EIP155, the signature failed verification in the demo dapp: https://metamask.github.io/test-dapp/
refi93
force-pushed
the
setup-custom-app-secret
branch
from
31badec to
5b775de
Compare
refi93
force-pushed
the
setup-custom-app-secret
branch
from
5b775de to
2ee4dc2
Compare
refi93
force-pushed
the
setup-custom-app-secret
branch
from
2ee4dc2 to
4baf1da
Compare
|
this change was made in #577 with more helpful features for bridging the gap between the two interfaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: We'd like to be able to use the setup method with the same flow that Metamask/Rabby wallets do (i.e. redirection through lattice connector which takes care of the pairing instead of custom logic within the wallet app) and for that we need to create the same app secret which is however not the case for the implementation of the setup() method (notice the different order of parameters passed to the hashing function which generates the app secret) :
Metamask/Rabby app secret: https://github.com/GridPlus/eth-lattice-keyring/blob/c22352bd35c895d25700f19d50ff932d680ec66a/index.js#L683-L686
gridplus-sdk setup implementation:
gridplus-sdk/src/util.ts
Lines 666 to 670 in 68a8242
This PR solves our problem by exposing an optional
appSecretparameter which allows to override the defaultappSecretgenerated in thesetup()calladditionally, this PR addresses an issue we came across with
bignumber.jsbeing possibly encoded correctly, which happened if package manager chose to supply a different version of bignumber.js to gridplus-sdk vs theborclib which is internally used to encode payloads. This should be prevented by making sure the version ofbignumber.jsrequired bygridplus-sdkmatches exactly the one required byborc