Skip to content

Commit

Permalink
Merge pull request #340 from GridPlus/update-bridge-language
Browse files Browse the repository at this point in the history
Fixes ETH v2 bridge language
  • Loading branch information
alex-miller-0 authored Mar 22, 2022
2 parents 8b5a7eb + fbe1ef4 commit b69d2bd
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,9 @@ export class Client {
// In v0.15.0 Lattice firmware removed the legacy ETH signing path, so
// we need to convert such requests to general signing requests using
// the EVM decoder.
// NOTE: Not every request can be converted, so users should switch
// to using general signing requests for newer firmware versions.
// EIP1559 and EIP155 legacy requests will convert, but others may not.
const useEVMDecoder = (
fwConstants.genericSigning &&
fwConstants.genericSigning.encodingTypes &&
Expand All @@ -431,7 +434,8 @@ export class Client {
payload = ethereum.ethConvertLegacyToGenericReq(data);
} catch (err) {
return cb(
`Please update Lattice firmware. Request failed. ${err.message}`
'Could not convert legacy request. Please switch to a general signing ' +
'request. See gridplus-sdk docs for more information.'
);
}
data = {
Expand Down

0 comments on commit b69d2bd

Please sign in to comment.