fix xpub handling

GridPlus · Jan 17, 2025 · 98e7033 · 98e7033
1 parent 1e17d74
commit 98e7033
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/__test__/e2e/xpub.test.ts b/src/__test__/e2e/xpub.test.ts
@@ -19,6 +19,6 @@ describe('XPUB', () => {
       flag: LatticeGetAddressesFlag.secp256k1Xpub,
     });
     expect(xpub).toHaveLength(1);
-    expect(xpub[0]).toMatch(/^xpub/); // XPUB should start with "xpub"
-    });
+    expect(xpub[0].startsWith('xpub')).toBe(true);
+  });
 });
diff --git a/src/functions/getAddresses.ts b/src/functions/getAddresses.ts
@@ -198,7 +198,12 @@ export const decodeGetAddressesResponse = (
       // Return the UTF-8 representation
       const len = addrBytes.indexOf(0); // First 0 is the null terminator
       if (len > 0) {
-        addrs.push(addrBytes.slice(0, len).toString());
+        // Clean control characters from the string before adding to array
+        const cleanStr = addrBytes
+          .slice(0, len)
+          .toString()
+          .replace(/[\x00-\x1F\x7F-\x9F]/g, '');
+        addrs.push(cleanStr);
       }
     }
   }