-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prom SeriesNormalize
plan
#787
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #787 +/- ##
===========================================
- Coverage 85.43% 85.25% -0.19%
===========================================
Files 414 418 +4
Lines 54221 54525 +304
===========================================
+ Hits 46325 46483 +158
- Misses 7896 8042 +146
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ruihang Xia <[email protected]>
* feat: impl SeriesNormalize plan Signed-off-by: Ruihang Xia <[email protected]> * some tests Signed-off-by: Ruihang Xia <[email protected]> * feat: add metrics Signed-off-by: Ruihang Xia <[email protected]> * add license header Signed-off-by: Ruihang Xia <[email protected]> * resolve CR comments Signed-off-by: Ruihang Xia <[email protected]> * update tests Signed-off-by: Ruihang Xia <[email protected]> * make time index column a parameter Signed-off-by: Ruihang Xia <[email protected]> * precompute time index column index Signed-off-by: Ruihang Xia <[email protected]> * sign the TODO Signed-off-by: Ruihang Xia <[email protected]> Signed-off-by: Ruihang Xia <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add
SeriesNormalize
plan described in the RFC.It only biases the timestamp column with "offset" and sorts the input.
Checklist
Refer to a related PR or issue link (optional)
#596