-
Notifications
You must be signed in to change notification settings - Fork 378
fix: skip replacing exprs of the DistinctOn node #5823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
d5a8c38
to
943057b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: handle distinct on specially * chore: update comment
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5799
What's changed and what's your intention?
Quick fix for the panic that
DistinctOn::with_new_exprs()
can't receivesort_expr
.This PR skips replacing exprs of the
DistinctOn
node.PR Checklist
Please convert it to a draft if some of the following conditions are not met.