-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl label_join and label_replace for promql #5153
feat: impl label_join and label_replace for promql #5153
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5153 +/- ##
==========================================
- Coverage 84.01% 83.80% -0.22%
==========================================
Files 1172 1175 +3
Lines 218098 219174 +1076
==========================================
+ Hits 183239 183669 +430
- Misses 34859 35505 +646 |
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 3 changed files in this pull request and generated 7 suggestions.
Files not reviewed (2)
- tests/cases/standalone/common/promql/label.result: Language not supported
- tests/cases/standalone/common/promql/label.sql: Language not supported
It's worth noting that in PromQL, passing an empty string for
then
I'm not sure if this would be handled downstream here, but I don't believe |
Thank you for your note; I'll test it now. |
@dekelpilli Looks like we can't remove the label in the current implementation right now. cc @waynexia We don't know the replaced results until executing the plan, it's not easy to implement in the current planner. I leave a todo and try to find a solution in the future. |
@waynexia @evenyag Ready for review, please take a look. Thanks @dekelpilli |
* feat: impl label_join and label_replace for promql * chore: style * fix: dst_label is eqauls to src_label * fix: forgot to sort the results * fix: processing empty source label
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5151
What's changed and what's your intention?
Impl the following functions for PromQL:
Checklist