-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Loki remote write #4941
base: main
Are you sure you want to change the base?
feat: Loki remote write #4941
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
699434c
to
8c26ce4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4941 +/- ##
==========================================
- Coverage 84.07% 83.76% -0.32%
==========================================
Files 1143 1148 +5
Lines 211918 214156 +2238
==========================================
+ Hits 178172 179382 +1210
- Misses 33746 34774 +1028 |
6ef3875
to
9cac101
Compare
value_data: Some(ValueData::StringValue(line)), | ||
}; | ||
// insert labels | ||
for (k, v) in labels.iter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can consume the labels to avoid cloning in the loop body.
for (k, v) in labels.iter() { | |
for (k, v) in labels.into_iter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One Loki push request contains multiple log entries. The labels are request-level attributes, so these would be appended to each row of log entry. Hence the iter()
instead of into_iter()
.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This pr mainly modifies
src/servers/src/http/event.rs
file:use Alloy config like the following to remote write to GreptimeDB using Loki remote write endpoint
Checklist