-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(index): add RangeReader
trait
#4718
feat(index): add RangeReader
trait
#4718
Conversation
Signed-off-by: Zhenchi <[email protected]>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Signed-off-by: Zhenchi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4718 +/- ##
==========================================
- Coverage 84.81% 84.53% -0.28%
==========================================
Files 1114 1114
Lines 200738 200672 -66
==========================================
- Hits 170247 169642 -605
- Misses 30491 31030 +539 |
Signed-off-by: Zhenchi <[email protected]>
* feat(index): add `RangeReader` trait` Signed-off-by: Zhenchi <[email protected]> * fix: return content_length as read bytes Signed-off-by: Zhenchi <[email protected]> * chore: remove buffer & use `BufMut` Signed-off-by: Zhenchi <[email protected]> --------- Signed-off-by: Zhenchi <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4717
What's changed and what's your intention?
Introduce
RangeReader
and apply forInvertedIndeFooterReader
andInvertedIndexBlobReader
.Checklist