Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inverted_index.search): add fst values mapper #2862

Merged
merged 12 commits into from
Dec 4, 2023

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Dec 4, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add FstValuesMapper to map FST-encoded u64 values to their corresponding bitmaps

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2705

The next PRs to be submitted:
feat(inverted_index.search): add index applier

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #2862 (65e47b7) into develop (58c1373) will decrease coverage by 0.42%.
Report is 3 commits behind head on develop.
The diff coverage is 92.59%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2862      +/-   ##
===========================================
- Coverage    84.77%   84.36%   -0.42%     
===========================================
  Files          743      745       +2     
  Lines       116811   116995     +184     
===========================================
- Hits         99026    98699     -327     
- Misses       17785    18296     +511     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongzc zhongzc added this pull request to the merge queue Dec 4, 2023
Merged via the queue into GreptimeTeam:develop with commit a9db80a Dec 4, 2023
13 checks passed
@zhongzc zhongzc self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants