Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement histogram_quantile in PromQL #2651

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Oct 24, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Implement histogram_quantile for conventional Prometheus histogram.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2651 (39ad950) into develop (fbc8f56) will decrease coverage by 0.45%.
Report is 4 commits behind head on develop.
The diff coverage is 66.93%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2651      +/-   ##
===========================================
- Coverage    84.95%   84.50%   -0.45%     
===========================================
  Files          743      743              
  Lines       120581   120828     +247     
===========================================
- Hits        102437   102109     -328     
- Misses       18144    18719     +575     

src/promql/src/planner.rs Outdated Show resolved Hide resolved
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia enabled auto-merge October 25, 2023 07:44
@waynexia waynexia requested review from sunng87 and yuanbohan October 25, 2023 07:45
@waynexia waynexia added this pull request to the merge queue Oct 25, 2023
Merged via the queue into GreptimeTeam:develop with commit f08a35d Oct 25, 2023
12 checks passed
@waynexia waynexia deleted the histogram-quantile branch October 25, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants