refactor(mito): define manifest related API #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
evenyag
approved these changes
Jul 12, 2023
evenyag
reviewed
Jul 12, 2023
coming soon 🥲 |
Codecov Report
@@ Coverage Diff @@
## develop #1942 +/- ##
===========================================
- Coverage 86.32% 85.76% -0.57%
===========================================
Files 614 618 +4
Lines 99346 99557 +211
===========================================
- Hits 85765 85386 -379
- Misses 13581 14171 +590 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* refactor: port some manifest struct to mito2 Signed-off-by: Ruihang Xia <[email protected]> * fix clippy and nextest Signed-off-by: Ruihang Xia <[email protected]> * revert lock file and resolve clippy warnings Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
There are too many abstractions around manifest. They were needed when we had region manifest and table manifest. In #1869 we are going to merge these two manifests. By doing this the implementation can also be simplified. Major change:
Checkpoint-> structRegionCheckpointMetaAction-> structRegionMetaActionListMetaActionIterator-> structMetaActionIteratorImplThe next step is to port
manifest/region.rsandmanifest/storage.rsChecklist
Refer to a related PR or issue link (optional)