Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hint api for Context #43

Merged
merged 1 commit into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ingester-rpc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,17 @@
<groupId>${project.groupId}</groupId>
<artifactId>ingester-common</artifactId>
</dependency>

<!-- test -->
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
</project>
24 changes: 24 additions & 0 deletions ingester-rpc/src/main/java/io/greptime/rpc/Context.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
@SuppressWarnings({"unchecked", "unused"})
public class Context implements Copiable<Context> {

private static final String HINT_PREFIX = "x-greptime-hint:";

private final Map<String, Object> ctx = new HashMap<>();

/**
Expand All @@ -48,6 +50,17 @@ public static Context of(String key, Object value) {
return new Context().with(key, value);
}

/**
* Creates a new {@link Context} with the specified hint key-value pair.
*
* @param key the hint key
* @param value the value
* @return the new {@link Context}
*/
public static Context hint(String key, Object value) {
return Context.of(HINT_PREFIX + key, value);
}

/**
* Adds the specified key-value pair to this {@link Context}.
*
Expand All @@ -62,6 +75,17 @@ public Context with(String key, Object value) {
return this;
}

/**
* Adds the specified hint key-value pair to this {@link Context}.
*
* @param key the hint key
* @param value the value
* @return this {@link Context}
*/
public Context withHint(String key, Object value) {
return with(HINT_PREFIX + key, value);
}

/**
* Gets the value of the specified key.
*
Expand Down
92 changes: 92 additions & 0 deletions ingester-rpc/src/test/java/io/greptime/rpc/ContextTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
/*
* Copyright 2023 Greptime Team
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.greptime.rpc;

import org.junit.Assert;
import org.junit.Test;

/**
* @author jiachun.fjc
*/
public class ContextTest {
@Test
public void newDefaultShouldReturnEmptyContextTest() {
Context context = Context.newDefault();
Assert.assertTrue(context.entrySet().isEmpty());
}

@Test
public void ofShouldReturnContextWithOneEntryTest() {
Context context = Context.of("key", "value");
Assert.assertEquals("value", context.get("key"));
}

@Test
public void hintShouldReturnContextWithHintEntryTest() {
Context context = Context.hint("key", "value");
Assert.assertEquals("value", context.get("x-greptime-hint:key"));
}

@Test
public void withShouldAddEntryToContextTest() {
Context context = Context.newDefault();
context.with("key", "value");
Assert.assertEquals("value", context.get("key"));
}

@Test
public void withHintShouldAddHintEntryToContextTest() {
Context context = Context.newDefault();
context.withHint("key", "value").with("key2", "value");
Assert.assertEquals("value", context.get("x-greptime-hint:key"));
Assert.assertEquals("value", context.get("key2"));
}

@Test
public void getShouldReturnNullForNonExistingKeyTest() {
Context context = Context.newDefault();
Assert.assertNull(context.get("key"));
}

@Test
public void removeShouldRemoveEntryFromContextTest() {
Context context = Context.of("key", "value");
String value = context.remove("key");
Assert.assertNull(context.get("key"));
Assert.assertEquals("value", value);
}

@Test
public void getOrDefaultShouldReturnDefaultValueForNonExistingKeyTest() {
Context context = Context.newDefault();
Assert.assertEquals("default", context.getOrDefault("key", "default"));
}

@Test
public void clearShouldRemoveAllEntriesFromContextTest() {
Context context = Context.of("key", "value");
context.clear();
Assert.assertTrue(context.entrySet().isEmpty());
}

@Test
public void copyShouldReturnIdenticalContextTest() {
Context context = Context.of("key", "value");
Context copy = context.copy();
Assert.assertEquals(context.get("key").toString(), copy.get("key").toString());
}
}