-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extended facing to single-block machines #2823
Open
omergunr100
wants to merge
22
commits into
GregTechCEu:1.20.1
Choose a base branch
from
omergunr100:1.20.1-single-rotation
base: 1.20.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add extended facing to single-block machines #2823
omergunr100
wants to merge
22
commits into
GregTechCEu:1.20.1
from
omergunr100:1.20.1-single-rotation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a config option to enable it
Refactored related methods into GTMatrixUtils. Added javadoc for unclear methods.
omergunr100
added
type: refactor
Suggestion to refactor a section of code
Merge on Major Release
Breaking changes, must be bundled into an 1.X.0 Update
labels
Feb 10, 2025
should be fine and definitely will not cause crashes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Merge on Major Release
Breaking changes, must be bundled into an 1.X.0 Update
type: feature
New feature or request
type: refactor
Suggestion to refactor a section of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add the
allowExtendedFacing
property to single block machines to allow them to rotate in all orientations.Implementation Details
WIP
Outcome
Resolve #2816
Potential Compatibility Issues
TBD